Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Adds web-app remote file test #160

Merged
merged 11 commits into from
Mar 14, 2023
Merged

✅ Adds web-app remote file test #160

merged 11 commits into from
Mar 14, 2023

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Mar 10, 2023 •
edited
Loading

  • Adds a 'url' input field to the web app
  • Adds a simple node:http test server that can serve exactly one file (with range header support)
  • Works on small (~100 MB) files but fails on large (GB+) files

@dmihalcik-virtru
WIP Adds web-app remote file support
17523a6 
- Adds a 'url' input field to the web app
- Adds a simple node:http test server that can serve exactly one file (with range header support)
- Works on small (~100 KB) files but fails on large (GB+) files
@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review March 13, 2023 18:53
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner March 13, 2023 18:53
@dmihalcik-virtru dmihalcik-virtru changed the title WIP Adds web-app remote file support ✅ Adds web-app remote file test Mar 14, 2023
@dmihalcik-virtru
Copy link
Member Author

Hah it is failing on encrypt, not decrypt, so it isn't the chunker bug. I suspect it is just not throttling the download but IDK it could be a leak somewhere? It is strange that File streams don't trigger it but web streams do. I've had no luck so far, see #159

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.5% 0.5% Duplication

@dmihalcik-virtru dmihalcik-virtru merged commit 0344510 into opentdf:main Mar 14, 2023
@dmihalcik-virtru dmihalcik-virtru deleted the feature/url-remote-test branch March 14, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

@danielRicaud danielRicaud Awaiting requested review from danielRicaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmihalcik-virtru @pflynn-virtru