[api] enable DIAG_GET query function into commissioner #298

ZhangLe2016 · 2024-09-27T08:57:56Z

This PR adds DIAG_GET query command into the commissioner module, allowing users to query diagnostic TLV (Ipv6Address) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.

Test:
config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
start 192.168.9.2 49154
[done]
diag query ipaddr fdce:bb1d:37f6:6978:0:ff:fe00:cc00
Peer Address: fd74:95e3:6ec:feee:0:ff:fe00:ac00
Content: {
"Ipv6 Addresses": [
"fd74:95e3:06ec:feee:0000:00ff:fe00:fc36",
"fd74:95e3:06ec:feee:0000:00ff:fe00:fc11",
"fd74:95e3:06ec:feee:0000:00ff:fe00:fc10",
"fd74:95e3:06ec:feee:0000:00ff:fe00:fc38",
"fd11:0022:0000:0000:99e7:cece:d50d:ae6b",
"fd74:95e3:06ec:feee:0000:00ff:fe00:fc00",
"fd74:95e3:06ec:feee:0000:00ff:fe00:ac00",
"fd74:95e3:06ec:feee:6142:033d:b087:2845",
"fe80:0000:0000:0000:9cbb:e247:df46:9e70"
]
}
[done]

This PR adds DIAG_GET query command into the commissioner module, allowing users to query one or more diagnostic TLVs from a peer Thread device by setting the device's mesh local address than TLV mask bits flag. Test: config set pskc 445f2b5ca6f2a93a55ce570a70efeecb [done] start 192.168.9.2 49154 [done] diag query ipaddr fdce:bb1d:37f6:6978:0:ff:fe00:cc00 { "Ipv6 Addresses": [ "fdcebb1d37f66978000000fffe00fc31", "fdcebb1d37f66978000000fffe00fc11", "fdcebb1d37f66978000000fffe00fc10", "fdcebb1d37f66978000000fffe00fc38", "fd110022000000000effb88e150d6192", "fdcebb1d37f66978000000fffe00fc00", "fdcebb1d37f66978000000fffe00cc00", "fdcebb1d37f669786346d24762e87ba8", "fe80000000000000bcda411761f56516" ] } [done]

This PR adds DIAG_GET query command into the commissioner module, allowing users to query one or more diagnostic TLVs from a peer Thread device by setting the device's mesh local address than TLV mask bits flag. Test: config set pskc 445f2b5ca6f2a93a55ce570a70efeecb [done] start 192.168.9.2 49154 [done] diag query ipaddr fdce:bb1d:37f6:6978:0:ff:fe00:cc00 Peer Address: fd74:95e3:6ec:feee:0:ff:fe00:ac00 Content: { "Ipv6 Addresses": [ "fd74:95e3:06ec:feee:0000:00ff:fe00:fc36", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc11", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc10", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc38", "fd11:0022:0000:0000:99e7:cece:d50d:ae6b", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc00", "fd74:95e3:06ec:feee:0000:00ff:fe00:ac00", "fd74:95e3:06ec:feee:6142:033d:b087:2845", "fe80:0000:0000:0000:9cbb:e247:df46:9e70" ] } [done]

This PR adds DIAG_GET query command into the commissioner module, allowing users to query diagnostic TLV (ipv6Address) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag. Test: config set pskc 445f2b5ca6f2a93a55ce570a70efeecb [done] start 192.168.9.2 49154 [done] diag query ipaddr fdce:bb1d:37f6:6978:0:ff:fe00:cc00 Peer Address: fd74:95e3:6ec:feee:0:ff:fe00:ac00 Content: { "Ipv6 Addresses": [ "fd74:95e3:06ec:feee:0000:00ff:fe00:fc36", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc11", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc10", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc38", "fd11:0022:0000:0000:99e7:cece:d50d:ae6b", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc00", "fd74:95e3:06ec:feee:0000:00ff:fe00:ac00", "fd74:95e3:06ec:feee:6142:033d:b087:2845", "fe80:0000:0000:0000:9cbb:e247:df46:9e70" ] } [done]

wgtdkp · 2024-10-16T07:14:12Z

include/commissioner/commissioner.hpp

+     * @param[in] aDiagAnsMsg   Parsed DiagTlvs data.
+     *
+     */
+    virtual void OnDiagGetAnswerMessage(const std::string &aDestAddress, const NetDiagData &aDiagAnsMsg)


The other callbacks use the name aPeerAddr for the device which sends the response, can we follow the naming here?

Suggested change

virtual void OnDiagGetAnswerMessage(const std::string &aDestAddress, const NetDiagData &aDiagAnsMsg)

virtual void OnDiagGetAnswerMessage(const std::string &aPeerAddr, const NetDiagData &aDiagAnsMsg)

wgtdkp · 2024-10-16T07:19:17Z

include/commissioner/network_diag_data.hpp

+/**
+ * @brief IPv6 Addresses List
+ */
+struct Ipv6AddressList


This class is not necessary, please remove

this data structure will be reused into the ChildIpv6Address, which includes the child's rloc16 and Ipv6AddressList two fields, we could reuse this data structure decode function into the ChildIpv6Address .

Why can't ChildIpv6Address use std::vector<std::string> directly?

I think it is more reasonable for Ipv6AddressList as a sub structure of ChildIpv6Address and NetDiagData.

wgtdkp · 2024-10-16T07:19:56Z

include/commissioner/network_diag_data.hpp

+ * meaningful only when associative PresentFlags is included in
+ * `mPresentFlags`.
+ */
+struct NetDiagData


Is it intended that this class is almost empty? I think it should include all possible fields.

the previous PR is too large with all possible fields, can we split them into some small PR for code review?

Sure.

But it's better to review and submit the NetDiagData definition and decoding before providing an API to request for NetDiagData. Let me know when you get the NetDiagData class PR ready.

I am stopping reviewing this CL now.

okay, let me provide a new PR for it.

new PR #303 is ready for your comments, Thanks.

This PR adds DIAG_GET query command into the commissioner module, allowing users to query diagnostic TLV (ipv6Address) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag. Test: config set pskc 445f2b5ca6f2a93a55ce570a70efeecb [done] start 192.168.9.2 49154 [done] diag query ipaddr fdce:bb1d:37f6:6978:0:ff:fe00:cc00 Peer Address: fd74:95e3:6ec:feee:0:ff:fe00:ac00 Content: { "Ipv6 Addresses": [ "fd74:95e3:06ec:feee:0000:00ff:fe00:fc36", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc11", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc10", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc38", "fd11:0022:0000:0000:99e7:cece:d50d:ae6b", "fd74:95e3:06ec:feee:0000:00ff:fe00:fc00", "fd74:95e3:06ec:feee:0000:00ff:fe00:ac00", "fd74:95e3:06ec:feee:6142:033d:b087:2845", "fe80:0000:0000:0000:9cbb:e247:df46:9e70" ] } [done]

…pdated accordingly

ZhangLe2016 · 2024-11-25T06:04:27Z

closed this PR and created a new PR #304

ZhangLe2016 added 12 commits September 27, 2024 08:51

ZhangLe2016 requested review from wgtdkp and lanyuwen October 9, 2024 09:15

ZhangLe2016 added 4 commits October 16, 2024 07:07

wgtdkp reviewed Oct 16, 2024

View reviewed changes

ZhangLe2016 added 5 commits October 16, 2024 07:44

As the network_diag_data is updated, the API implementation is also u…

c645bc8

…pdated accordingly

Merge branch 'main' into diag-api-qry

06b548e

restore the network_diag_data module

1e18794

ZhangLe2016 closed this Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[api] enable DIAG_GET query function into commissioner #298

[api] enable DIAG_GET query function into commissioner #298

ZhangLe2016 commented Sep 27, 2024 •

edited

Loading

wgtdkp Oct 16, 2024

ZhangLe2016 Oct 16, 2024

wgtdkp Oct 16, 2024

ZhangLe2016 Oct 16, 2024

wgtdkp Oct 16, 2024

ZhangLe2016 Oct 16, 2024

wgtdkp Oct 16, 2024

ZhangLe2016 Oct 16, 2024

wgtdkp Oct 16, 2024

ZhangLe2016 Oct 16, 2024

ZhangLe2016 Oct 16, 2024

ZhangLe2016 commented Nov 25, 2024

	virtual void OnDiagGetAnswerMessage(const std::string &aDestAddress, const NetDiagData &aDiagAnsMsg)
	virtual void OnDiagGetAnswerMessage(const std::string &aPeerAddr, const NetDiagData &aDiagAnsMsg)

[api] enable DIAG_GET query function into commissioner #298

[api] enable DIAG_GET query function into commissioner #298

Conversation

ZhangLe2016 commented Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZhangLe2016 commented Nov 25, 2024

ZhangLe2016 commented Sep 27, 2024 •

edited

Loading