[api] enable DIAG_GET query function into commissioner #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owing users to query diagnostic TLV (Ipv6Address) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
> start 192.168.9.2 49154
[done]
> diag query extmac
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
> diag query rloc16 fda1:7966:fc90:d97:0:ff:fe00:bc00
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"MacAddr": 48128
}
[done]
…owing users to query diagnostic TLV (Ipv6Address) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
>> diag query extmac
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
>> diag query rloc16 fda1:7966:fc90:d97:0:ff:fe00:bc00
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"MacAddr": 48128
}
[done]
…owing users to query diagnostic TLV (Ipv6Address) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
>> diag query extmac
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
>> diag query rloc16 fda1:7966:fc90:d97:0:ff:fe00:bc00
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"MacAddr": 48128
}
[done]
…owing users to query diagnostic TLV (Ipv6Address) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
>> diag query extmac
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
>> diag query rloc16 fda1:7966:fc90:d97:0:ff:fe00:bc00
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"MacAddr": 48128
}
[done]
ZhangLe2016
changed the title
wgtdkp
reviewed
Nov 25, 2024
This PR adds DIAG_GET query command into the commissioner module, allowing users to query diagnostic TLV (extaddr) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
>> diag query extaddr
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
This PR adds DIAG_GET query command into the commissioner module, allowing users to query diagnostic TLV (extaddr) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
>> diag query extaddr
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
wgtdkp
reviewed
Nov 25, 2024
This PR adds DIAG_GET query command into the commissioner module, allowing users to query diagnostic TLV (extaddr) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
>> diag query extaddr
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
This PR adds DIAG_GET query command into the commissioner module, allowing users to query diagnostic TLV (extaddr) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
>> diag query extaddr
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
wgtdkp
approved these changes
Nov 25, 2024
This PR adds DIAG_GET query command into the commissioner module, allowing users to query diagnostic TLV (extaddr) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test:
>> config set pskc 445f2b5ca6f2a93a55ce570a70efeecb
[done]
>> start 192.168.9.2 49154
[done]
>> diag query extaddr
Peer Address: fda1:7966:fc90:d97:0:ff:fe00:bc00
Content: {
"ExtMacAddr": "6e56946f67040080"
}
[done]
|
@jwhui , could you please review this PR for me? Thanks a lot. |
|
@jwhui Could you please take a look at my code? I would be very grateful for your feedback. |
jwhui
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DIAG_GET query command into the commissioner module, all owing users to query diagnostic TLV (ExtMacAddr) from a peer Thread device by setting the device's mesh local address than TLV mask bits flag.
Test: