Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/Reload npc not reloading npcs #570

Closed
2 of 5 tasks
Deadsmelly opened this issue Nov 5, 2022 · 0 comments · Fixed by #669
Closed
2 of 5 tasks

/Reload npc not reloading npcs #570

Deadsmelly opened this issue Nov 5, 2022 · 0 comments · Fixed by #669
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Deadsmelly
Copy link

Priority

Low

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

Using the /reload npcs or /reload scripts does not reload the npcs.

To test

  • Change any npc dialog greeting to say something different.
  • Save file.
  • Use GM char to /reload npcs or /reload scripts
  • Talk to npc, npc still says old greeting.
  • Restart server
  • Talk to npc, npc will now say new greeting.

Example: Thais weapon/armor vendor Sam.

Normal greeting: Welcome to my shop, adventurer GOD! I trade with weapons and armor.

Changed greeting: "This is a test"
image

image

image

After server restart
image

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Deadsmelly Deadsmelly added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 5, 2022
@github-actions github-actions bot added map Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Nov 5, 2022
@beats-dh beats-dh removed map labels Dec 6, 2022
@murilo09 murilo09 linked a pull request Dec 8, 2022 that will close this issue
[Enhancement] reorganize reload functions and extract in an own class on cpp #669
Merged
luan pushed a commit that referenced this issue Jul 23, 2023
@jarrodpjohnston @luan
feat(elysiera): blockade npcs, close gnomeprona, banuta shortcuts (#570)
5df9e4a 
* feat(elysiera): blockade npcs, close gnomeprona, banuta shortcuts

* chore(elysiera): remove print
luan pushed a commit that referenced this issue Jul 27, 2023
@jarrodpjohnston @luan
feat(elysiera): blockade npcs, close gnomeprona, banuta shortcuts (#570)
5a02c0c 
* feat(elysiera): blockade npcs, close gnomeprona, banuta shortcuts

* chore(elysiera): remove print
luan pushed a commit that referenced this issue Jul 27, 2023
@jarrodpjohnston @luan
feat(elysiera): blockade npcs, close gnomeprona, banuta shortcuts (#570)
f4485d3 
* feat(elysiera): blockade npcs, close gnomeprona, banuta shortcuts

* chore(elysiera): remove print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] reorganize reload functions and extract in an own class on cpp opentibiabr/canary
2 participants
@beats-dh @Deadsmelly