[Enhancement] reorganize reload functions and extract in an own class on cpp #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dudantas
changed the title
marcosvf132
approved these changes
Dec 8, 2022
|
Kudos, SonarCloud Quality Gate passed! |
beats-dh
approved these changes
Dec 8, 2022
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
… on cpp (#669) • Fixed some bugs in the reload, moved the reload function to its own lib, which is the beginning of the migration of all talkactions to this lib, this will allow us to: Use the "/reload talkactions" command, thus returning to the old way of reloading only certain classes. • Fixed crash related to "/reload monster" and "/reload scripts" • Fixed some reloads not working correctly • Fixed "/reload npc" • Created a new class for reload, facilitating the understanding and organization of functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fixed some bugs in the reload, moved the reload function to its own lib, which is the beginning of the migration of all talkactions to this lib, this will allow us to:
Use the "/reload talkactions" command, thus returning to the old way of reloading only certain classes.
• Fixed crash related to reload monster and reload scripts
• Fixed some reloads not working correctly
• Created a new class for reload, facilitating the understanding and organization of functions.