Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: distance weapons shouldn't hit with fists when without ammo #755

Merged
merged 9 commits into from
Feb 4, 2023
Merged

fix: distance weapons shouldn't hit with fists when without ammo #755

merged 9 commits into from
Feb 4, 2023

Conversation

ElimarCosta
Copy link
Contributor

Description

Distance weapons shouldn't hit with fist when without ammo

Behaviour

Actual

Distance weapons do hit with fists when without ammo

Expected

Distance weapons shouldn't hit with fists when without ammo

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@murilo09 murilo09 linked an issue Jan 9, 2023 that may be closed by this pull request
Attacking with bow without ammo #677
Closed
7 tasks
@murilo09 murilo09 changed the title Distance weapons shouldn't hit with fists when without ammo fix: distance weapons shouldn't hit with fists when without ammo Jan 15, 2023
murilo09
murilo09 requested changes Jan 15, 2023
View reviewed changes
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/creatures/players/player.cpp Outdated Show resolved Hide resolved
ElimarCosta and others added 3 commits January 15, 2023 15:13
@ElimarCosta @murilo09
Update src/creatures/players/player.cpp
48f0c8a 
Co-authored-by: murilo09 <78226931+murilo09@users.noreply.github.com>
@ElimarCosta @murilo09
Update src/creatures/players/player.cpp
f4d9be5 
Co-authored-by: murilo09 <78226931+murilo09@users.noreply.github.com>
@ElimarCosta
Merge branch 'main' into bug-weapon-distance-fist
c00d35d
@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 43a7f73 into opentibiabr:main Feb 4, 2023
@ElimarCosta ElimarCosta deleted the bug-weapon-distance-fist branch February 7, 2023 17:07
dudantas pushed a commit to dudantas/canary that referenced this pull request Feb 7, 2023
@ElimarCosta @dudantas
fix: distance weapons shouldn't hit with fists when without ammo (ope…
f8ec3b4 
…ntibiabr#755)

Previously, distance weapons could hit with fists even when out of ammo. This has been fixed.
@dudantas dudantas mentioned this pull request Feb 17, 2023
Merged
1 task
LeoTKBR added a commit to LeoTKBR/canary that referenced this pull request Feb 18, 2023
@LeoTKBR
Squashed commit of the following:
cc7f52c 
commit 788f172
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Fri Feb 17 20:07:53 2023 -0300

    fix: delete unnecessary script check_inbox.lua (opentibiabr#866)

    Probably an inheritance from the OTX, in addition to not being necessary, it calls a table that does not exist "player".
    It must have been created at the time that tibia only allowed 10k items in the inbox.

commit 1ddb4a9
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Fri Feb 17 19:28:56 2023 -0300

    fix: interaction with fields and removal of unused flag (opentibiabr#865)

    Interaction with fields, fixes opentibiabr#67
    Removal of unused flag changed in opentibiabr#823

commit 1f8eabf
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Fri Feb 17 19:28:13 2023 -0300

    improve: fixes cyclopedia and market items description (opentibiabr#826)

    Fixing cyclopedia and market items description.

commit c02e8a2
Author: LeoTK <41605307+LeoTKBR@users.noreply.github.com>
Date:   Fri Feb 17 19:23:37 2023 -0300

    fix: dangerous depth entrance (change from aid to position) (opentibiabr#863)

commit 144551a
Author: Beats <61994374+beats-dh@users.noreply.github.com>
Date:   Fri Feb 17 18:22:48 2023 -0400

    improve: canary datapack functionality with bug fixes and adjust (opentibiabr#665)

    Fixes several problems in the canary datapack and tweaked some functions and libs for better behaviour.

commit 3ca8f7d
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Fri Feb 17 19:20:05 2023 -0300

    feat: add example script for modal window (opentibiabr#855)

    This depends on the pull request: opentibiabr#794

commit ff4235e
Author: Marco Oliveira <marcomoa@hotmail.com>
Date:   Fri Feb 17 18:45:15 2023 -0300

    improve: handling of modal window helper (opentibiabr#794)

    This adds the possibility to create modal window in a more beautiful way.

    The order of execution of the calls is:
    • choice
    • button
    • default

    If a choice has a callback it will be activated when you press any button, however the button function will not be activated even if it has one. If another choice does not have a callback, the button callback is called, finally the default callback will be called if there is no callback associated with the button or the choice.

    Credits to authors are given in the pull request description.

commit 3069e02
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Fri Feb 17 12:37:05 2023 -0300

    fix: depot items not saving (opentibiabr#868)

    In the pull request opentibiabr#846 there were many conflicts due to the merge of the clang (opentibiabr#775) pull request, in the resolution of the conflicts, the depot load code ended up being removed, and it went unnoticed, this reverts those changes.

commit 09e7c14
Author: Karin <pessoacarlos98@gmail.com>
Date:   Fri Feb 17 05:06:39 2023 -0300

    feat: new lua event "onInventoryUpdate" (opentibiabr#751)

    Added a new c++ callback to Lua event on user to handle the inventory item update.

commit 5c53a39
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Fri Feb 17 00:28:05 2023 -0300

    fix: monsters/summons can walk no-walkable items after set unique id (opentibiabr#856)

    This fixes an issue where monsters and summons could walk on non-walkable items after their unique ID had been set. The fix ensures that the pathfinding algorithm takes these non-walkable items into account when moving the monsters and summons, preventing them from moving through areas that are designated as non-walkable.

commit bd872b9
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Wed Feb 15 09:30:18 2023 -0300

    fix: remove shared_ptr from reward and others fixes (opentibiabr#860)

    It is a bit more complex to switch to automatic memory management, it is necessary to modify the Game::cleanup function and other functions, as all items are checked there for cleanliness. In the future, maybe we'll modify this, for now it's better to keep it as manual pointer management.

    Also fixed some behaviours and issues related to the reward chest.

    Complement of: opentibiabr@8a1046a

    Co-author: @ElimarCosta

commit f7fef7c
Author: Peixonauta2 <63183357+Peixonauta2@users.noreply.github.com>
Date:   Tue Feb 14 01:30:45 2023 -0300

    fix: gamestore purchase history on ARM architecture (opentibiabr#812)

    This commit addresses an issue where the gamestore purchase history was not being properly stored on servers running on ARM architecture. While the problem did not occur on Windows, it affected other systems and was causing frustration for players. This fix ensures that the purchase history is stored correctly on all platforms, without causing any problems for Windows servers.

commit 4b1d92c
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Mon Feb 13 02:11:00 2023 -0300

    fix: player auto id (resolves 65536 player GUID max size) (opentibiabr#763)

    When the number of registered players in the database exceeds the limit of uint32_t, an overflow occurs and players are unable to move.

commit be7a0db
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Mon Feb 13 02:06:07 2023 -0300

    feat: implement bosstiary system (opentibiabr#700)

    Implements the recently launched Bosstiary system into the game. Bosstiary is an addition to the in-game encyclopedia, allowing players to keep track of which bosses they have defeated and how many times. As players progress through the system, they will receive useful and sophisticated rewards such as equipment loot bonuses, temporary and permanent titles, and the ability to display the defeated boss on a Vigor Podium in their house or guild. Additionally, Bosstiary also features a daily strengthened boss, randomly selected each server save. This change implements all the aforementioned aspects of Bosstiary into the game engine.

commit 5aa0b55
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Mon Feb 13 01:29:00 2023 -0300

    fix: add migrations to create "towns" table (opentibiabr#859)

    Complement of: opentibiabr@abdf22f

commit 8a1046a
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Sun Feb 12 23:59:40 2023 -0300

    fix: empty reward bags should disappear and others things (opentibiabr#846)

    This change aims to resolve the issue with reward bags in the game. Currently, reward bags do not disappear after closing and reopening the reward chest. On the global tibia, it is possible to have more than 100 reward bags, but this leads to strange behaviour if you re-login. Additionally, when multiple bosses are killed at the same time, the rewards are mixed and only one reward bag is created with the combined loot.

    The goal is to make the reward bags disappear properly after closing and reopening the reward chest, fix the limit of 100 reward bag, and prevent the mixing of rewards when multiple bosses are killed at the same time.

commit a26cd9c
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Sun Feb 12 17:10:38 2023 -0300

    fix: attribute integer not working (opentibiabr#854)

    The "is_integral" was not working, causing integer attributes not to be read.

    Complement of commit: opentibiabr@46b2c5e

commit 55133f8
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Sun Feb 12 14:59:41 2023 -0300

    fix: npc "poff" on hit and walk on fields and others (opentibiabr#853)

    • Fixed general fixes, NPC "poff" on hit and walk on fields, window projectile blocking and NPC speech bubble.

    The NPCs now ignore area damage (not "poffing") and do not traverse condition fields;
    Closed windows now obstruct projectiles, while open ones allow them;
    The NPC speech bubbles now display correctly with normal icon (...) as default and the trade (small bag) for NPC's with items to trade also with the option to modify the settings in the NPC's Lua configuration file.

commit 6b69b23
Author: Karin <pessoacarlos98@gmail.com>
Date:   Sun Feb 12 04:47:58 2023 -0300

    fix: prevent bugs in transfer coins (opentibiabr#714)

    Added:
    • New method to lua from source;
    • Delay in parseTransferCoins.

commit ecc0642
Author: Beats <61994374+beats-dh@users.noreply.github.com>
Date:   Sun Feb 12 03:46:45 2023 -0400

    improve: added clang format using GHA for code format (opentibiabr#775)

    This implements the Clang formatter, a linter, to maintain a consistent code style throughout the code base.

    In addition to configuring the Clang formatter, a GH Action has been added to automatically run the linter on the code base every time a push or pull request is made and make a commit to apply the format whenever necessary. This way, we can guarantee that the code is always in the same format.

    This also allows us to merge faster, as we can simply apply the linter to any open pull request to resolve any conflicts or changes that may occur during the merge.

commit 4989291
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Sun Feb 12 04:11:44 2023 -0300

    fix: loop in movement "stepin/out" and "addItem/remove" events (opentibiabr#742)

    A potential infinite loop was discovered in specific scenarios involving teleport squares or items that teleport players to specific locations (such as when the player logs in). This pull request addresses the issue by disabling the onStepIn event during login and implementing additional security checks to prevent similar bugs from occurring in the future.

commit 70cf05b
Author: Beats <61994374+beats-dh@users.noreply.github.com>
Date:   Sun Feb 12 02:45:01 2023 -0400

    fix: rate experience stages (opentibiabr#720)

commit abdf22f
Author: Gabriel Pedro <gpedro@users.noreply.github.com>
Date:   Sun Feb 12 02:32:45 2023 -0400

    fix: "towns" table database fill issue (opentibiabr#743)

    The towns table was not being populated properly after server startup, causing bugs on the web AAC. This aims to fix this issue and ensure proper data filling in the towns database.

commit 0b7f639
Author: Jackye <91164222+jacksonie@users.noreply.github.com>
Date:   Sun Feb 12 02:18:24 2023 -0300

    fix (global datapack): wrath of the emperor teleport (opentibiabr#792)

commit c7a18fb
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Sun Feb 12 02:04:53 2023 -0300

    fix: house clean-up and item wrap issues (opentibiabr#840)

    This fixes two issues related to the '!leavehouse' command. Firstly, all items inside the house should be moved to the owner's mailbox after using the command. Secondly, it should now be possible to wrap unrolled carpets.

    Fixes opentibiabr#631: bug causing exposed items after using the '!leavehouse' command, which allowed the new owner of the house to claim those items)."

commit 60cb39b
Author: Beats <61994374+beats-dh@users.noreply.github.com>
Date:   Sat Feb 11 23:53:01 2023 -0400

    fix: high CPU usage issue on linux (opentibiabr#849)

commit 0d8d95f
Author: Paulo Henrique Lisboa <39601778+Glatharth@users.noreply.github.com>
Date:   Sat Feb 11 14:27:34 2023 -0300

    feat: standardize lever functionality (opentibiabr#648)

    This introduces a new standardized function for levers in the game. This function has already been implemented in the Ferumbras' Ascendant Quest, ensuring a consistent and efficient lever experience for players.

commit 415492d
Author: Beats <61994374+beats-dh@users.noreply.github.com>
Date:   Fri Feb 10 00:32:12 2023 -0400

    build: deactivate build windows debug (opentibiabr#843)

commit 0a5a5f2
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Tue Feb 7 19:01:33 2023 -0300

    ci: remove action build for drafts (opentibiabr#844)

    GitHub Actions will not run on draft prs.

commit 38538c6
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Tue Feb 7 11:23:33 2023 -0300

    set target when convince creature (opentibiabr#845)

    Convinced creature should attack same target as master
    Fixes opentibiabr#539

commit 473690d
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Tue Feb 7 11:08:11 2023 -0300

    fix: change curl version to 1.3 (opentibiabr#847)

commit ebd28a8
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Mon Feb 6 15:06:39 2023 -0300

    fix: players shouldn't pathfind through fields (opentibiabr#756)

commit f0408d9
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Mon Feb 6 15:05:37 2023 -0300

    fix: remove money lua function should remove money from bank too (opentibiabr#760)

commit 7174dcf
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Mon Feb 6 15:04:04 2023 -0300

    fix: NPC Ongulf (opentibiabr#759)

    In the opentibiabr/otservbr-global#781 fixing the `The New Frontier Quest`, mistakenly replaced Ongulf's script with Leeland's script. Reverting to the correct script.

commit 05778b3
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Mon Feb 6 15:02:34 2023 -0300

    fix: using a shovel on a stonepile should move to downstairs (opentibiabr#757)

commit 5c50c5e
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Mon Feb 6 15:01:01 2023 -0300

    feat: added outfit and mount preview feature to the store (opentibiabr#773)

    This change adds the new outfit and mount preview feature in the Tibia game store. In addition to the new interface, which offers a better structured and layout, players can now try out all the available outfits and mounts before purchasing them.

commit 27737e6
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Mon Feb 6 14:26:59 2023 -0300

    fix: some errors and nil value in lua scripts (opentibiabr#830)

commit bf10756
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Mon Feb 6 14:01:12 2023 -0300

    fix: client debug and show not targeting player when dying near temple (opentibiabr#841)

    The issue arose because the multi-floor was not properly verified, causing incorrect identification of some creatures.

commit 46b2c5e
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Mon Feb 6 12:08:23 2023 -0300

    improve: rework of Item Attributes for better stability/maintability (opentibiabr#827)

    This brings in a major overhaul of the Item Attributes component, addressing long-standing issues in the TFS and OpenTibiaServer project. Adopting class inheritance and harnessing the latest capabilities of C++, this update resolves specific crashes and streamlines future changes to the code. The Attributes class has been separated into its own file, making the code more readable and easier to understand, while also removing any confusing and redundant functions from the Item class. This results in a more stable, maintainable, and user-friendly solution for Item Attributes.

    Simplified code by moving to shared_ptr for memory management, removing redundant functions, and revamping key classes such as Attributes, ItemAttribute, and CustomAttribute. The deprecated "set/getSpecialAttribute" functions have been replaced with more efficient "set/getCustomAttribute." This simplified approach leads to better code maintenance and increased stability, for example, Hirelings now utilize the CustomAttribute.

commit 434efda
Author: Aerwix <aerwix@criptext.com>
Date:   Mon Feb 6 07:53:14 2023 -0600

    fix: Canary NPC example addModule missing parameters (opentibiabr#842)

    Now the NPCs are displayed correctly and everything appears to be functional.
    Previously, they were not working in Ghost mode and this is what they looked like.

    If you have custom NPCs like I do, and created them some time ago, you may need to update them to function correctly.
    Change "npcHandler:addModule(FocusModule:new())" to
    "npcHandler:addModule(FocusModule:new(), npcConfig.name, true, true, true)"

commit 09e4e70
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Sun Feb 5 02:10:47 2023 -0300

    fix: compilation with new version mio library from vcpkg (opentibiabr#832)

    Recently, in a vcpkg commit, there was a problem linking the library mio. This caused issues when trying to link the executable. To solve this, I decided to revert to using an older version of the library until there is a correction in the vcpkg repository.

    To prevent future build breaks due to changes in the vcpkg repository, I added a step in the GitHub Actions to install vcpkg based on the builtin-baseline in the vcpkg.json file. This allows us to set vcpkg to be installed from specific commits in both GitHub Actions and in Ubuntu/Windows, centralizing everything in one location. We can only update vcpkg when there is an official release.

commit 97f3e8c
Author: Karin <pessoacarlos98@gmail.com>
Date:   Sun Feb 5 01:01:07 2023 -0300

    fix: add missing items on unscripted equipments (opentibiabr#782)

    Not working the absorb percent due to not being in unscripted_equipments.lua

commit d52581f
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Sat Feb 4 19:17:33 2023 -0300

    fix: monster target list erasing after player died (opentibiabr#839)

    When dying, the spectator's list of players was cleared, that is, if a player died, the target of all others was cleared.
    Also fixed the bug that when a player dies near the temple and a creature is in his sight, the creature will not target the player.

commit 3f6c671
Author: Beats <61994374+beats-dh@users.noreply.github.com>
Date:   Sat Feb 4 02:59:52 2023 -0400

    fix: server shutdown in ubuntu, resolves main thread loop (opentibiabr#838)

commit 0178967
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Sat Feb 4 03:11:00 2023 -0300

    fix: summons move items off the way and follow correct moving pattern (opentibiabr#823)

    Summons were failing to move objects blocking their path and not following the correct moving pattern. Improved summon behaviour to avoid randomly moving when unable to reach master or see him.

commit 6f07961
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Sat Feb 4 02:56:52 2023 -0300

    fix: charm/leech conditions, wound cleanse & life leech amount fix (opentibiabr#753)

    Fixes:
    • Conditions, fields and charms were incorrectly activating leech/charm, which does not occur on the official server;
    • Change in wound cleansing from minimum level 10 to 8;
    • Life leech to be more accurate with tibia global;

commit 24c79ef
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Sat Feb 4 01:16:44 2023 -0300

    fix: display imbuement damage reductions in cyclopedia (opentibiabr#819)

    This correction addresses the display of imbuement damage reductions in the cyclopedia. It is important to note that the modification only pertains to the visual aspect of the cyclopedia and the accuracy of the displayed damage reductions has not been verified. Please make sure to verify the accuracy of the information before applying this correction in production.

commit 65dde55
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Sat Feb 4 00:12:57 2023 -0300

    fix: stow all stowable items by moving depot above stash (opentibiabr#822)

    It should be possible to stow all storable items by moving the depot "above" the stash.

commit 43a7f73
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Fri Feb 3 22:54:45 2023 -0300

    fix: distance weapons shouldn't hit with fists when without ammo (opentibiabr#755)

    Previously, distance weapons could hit with fists even when out of ammo. This has been fixed.

commit d258953
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Wed Feb 1 09:53:15 2023 -0300

    fix: display speed attribute when looking items (opentibiabr#828)

    Ensure that items display their speed attribute value when being inspected. This will provide a more complete and accurate representation of the item's properties. Implement this change to enhance the user experience.

commit 9f85261
Author: PeachieDude <13871000+PeachieDude@users.noreply.github.com>
Date:   Fri Jan 27 22:28:29 2023 -0300

    fix: doors not opening/closing in canary datapack (opentibiabr#809)

commit b0f5662
Author: ElimarCosta <elimar.u.t.costa@gmail.com>
Date:   Fri Jan 27 22:18:20 2023 -0300

    fix: party hunt analyzer prices from leader (opentibiabr#817)

    The connection was being terminated upon altering the party hunt analyzer from market to leader, as the tibia client transmitted packages containing information on all cyclopedia items, and these package sizes exceeded what the server was able to accept.

    The party hunt analyzer was not being refreshed following the alteration of the party leader.

commit f853dbc
Author: Renato Machado <mehahx@gmail.com>
Date:   Fri Jan 27 22:03:50 2023 -0300

    improve: enabling checksum sequence method/compression in OTClient (opentibiabr#821)

    In this feature update, the OTClient Redemption now includes support for both the Checksum Sequence Method and compression. As a result, these features will be enabled by default to improve performance and data integrity for users.

commit b2fdfc7
Author: Elson Costa <elsongabriel@hotmail.com>
Date:   Fri Jan 27 11:45:17 2023 -0300

    feat: introducing configurable minimum level for house purchases (opentibiabr#814)

    Created a variable 'houseBuyLevel' in config.lua, to disable it, just put 0.

commit b10b3f4
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Wed Jan 25 00:44:14 2023 -0300

    fix: imbuement decay time (opentibiabr#818)

    Now the time decay logic of the imbuements is working as it should:
    • Backpacks imbuements will only decay if equipped in the backpack slot;
    • Normal item will only decay if in battle mode and out of protection zone, as well as in global.

commit 202f089
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Tue Jan 24 23:06:27 2023 -0300

    fix: assigning negative value to unsigned integer (getSkillLevel) (opentibiabr#769)

    Negative value was being assigned to an uint16_t, due to a wrong variable type in std::max.

commit 9de023f
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Fri Jan 20 16:42:27 2023 -0300

    fix: loop when open server without db (opentibiabr#807)

    After pr: opentibiabr#790 (opentibiabr@a870e01)

    Because it is no longer synchronous (does not fall into a loop), the server does not close after pressing "Enter" when opening without a database. This way, we need to send an exit for the console to close.

commit 12d8e25
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Fri Jan 20 15:44:36 2023 -0300

    fix: weapons, reverting some changes from XML pr (opentibiabr#784)

    Revert (and revise) some changes from: opentibiabr#740

    Fixes using weapons event (onUseWeapon)
    Fixes monsters spells invert order of target and caster

    Converted some raw pointers from "new" to "shared_ptr", thus ensuring that memory is automatically deallocated and no delete is needed, preventing memory leaks.

commit 691b976
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Fri Jan 20 15:20:16 2023 -0300

    improve: adding script name in lua scripts log errors (opentibiabr#800)

    Added a code change to log in the distro that allows it to report the Lua script name when there is a problem registering a script. This means that if an error occurs when registering a Lua script, it is now possible to easily identify which script is causing the problem, rather than just reporting that there was a general script registration error. This should help make the debugging and troubleshooting process easier.

commit c24b029
Author: Paulo Henrique Lisboa <39601778+Glatharth@users.noreply.github.com>
Date:   Fri Jan 20 13:43:56 2023 -0300

    feat: add function for loading/unloading OTBM files per offset (opentibiabr#436)

    Add a new function called 'loadMapChunk' which allows loading or unloading an OTBM file live on your server by using an offset. Note that the file must be mapped starting from x:0 y:0 coordinates for the offset to work properly.

commit eea9ed2
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Fri Jan 20 12:53:11 2023 -0300

    cd/ci: remove of GHA that are not working correctly (opentibiabr#801)

    Remove some GitHub Actions that are not working properly and are no longer needed.

commit fad589e
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Thu Jan 19 22:57:41 2023 -0300

    fix: exception handling, switch/if chain and others (opentibiabr#798)

    This fixes exception handling, switch/if chain, uninitialized variable, combat null pointers, and signed/unsigned comparison issues.

    Fixes several issues identified in the codebase. Firstly, it ensures that proper exception handling is in place to prevent unexpected termination of the program. Secondly, it eliminates the redundancy in switch and if chains by making sure that each branch has a unique implementation. Thirdly, it eliminates potential bugs caused by uninitialized variables by initializing all non-class type fields. Fourthly, it replaces dangerous comparison between signed and unsigned integers with std::cmp_* functions from C++20 to prevent counterintuitive results and lossy integer conversion. This improves the overall stability and security of the program.

commit 4b911bc
Author: Beats <61994374+beats-dh@users.noreply.github.com>
Date:   Thu Jan 19 15:10:15 2023 -0400

    improve: upgrade curl to use TLS version 1.2 (opentibiabr#705)

    This change updates the version of curl used in the project to version 7.64.0 or above, which includes support for Transport Layer Security (TLS) version 1.2. This update ensures that the project is using the most secure version of the protocol and is in compliance with industry security standards.

commit cd8119a
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Thu Jan 19 14:14:55 2023 -0300

    fix: some combat nullpointers (opentibiabr#788)

    Fixes pointers that were accessed without checking if they are nullptr, may cause unexpected behaviour.

commit 8f051d3
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Thu Jan 19 01:06:07 2023 -0300

    fix: close server console after done message (opentibiabr#796)

    After pr: opentibiabr#790 (opentibiabr@a870e01)

    Because it is no longer synchronous (does not fall into a loop), the server does not close after giving "CTRL + c" or receiving a safe sigbreak. This way, we need to send an exit for the console to close.

commit a870e01
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Wed Jan 18 17:53:02 2023 -0300

    fix: added condition argument to wait calls in threadMain functions (opentibiabr#790)

    This addresses the issues reported by SonarCloud regarding the use of wait() without a condition argument in several threadMain functions. The changes made include the addition of a condition argument to the wait() calls in the threadMain functions in the DatabaseTasks, Scheduler and other classes. These changes ensure that the threads will not wait indefinitely and will only wake up when there is a task to be executed, thus avoiding any potential race conditions and deadlocks.

commit bdd4b09
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Wed Jan 18 12:17:23 2023 -0300

    fix: added player nullpointer check (function updateCreatureType) (opentibiabr#791)

    Added null pointer check in Game::updateCreatureType function to ensure that there is no unexpected behaviour when accessing the object, and it does not exist.

commit d4ec6cc
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Tue Jan 17 19:02:51 2023 -0300

    fix: setLootContainer without accessing freed memory (opentibiabr#787)

    This change addresses an issue where the function setLootContainer and checkLootContainer was accessing a pointer after it had been freed by decrementing its reference counter (delete). This was causing a use of memory after it was freed error. It changes also moves the decrement reference counter line to the end of the function, making sure that the pointer is not accessed after it is freed.

commit 50963c5
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Tue Jan 17 19:00:35 2023 -0300

    fix: out of bounds memory access in setValue function (opentibiabr#785)

    This fix addresses a SonarCloud warning regarding an out-of-bounds memory access in the setValue function. Specifically, it checks that the row and col values passed to the function are within the bounds of the data_ array before performing the assignment. This ensures that the program will not attempt to access memory that is outside the allocated memory block, preventing potential crashes or other errors.

commit 2f252e2
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Tue Jan 17 17:01:53 2023 -0300

    fix: remove target without accessing freed memory (opentibiabr#786)

    This change addresses an issue where the function removeTarget was accessing a pointer after it had been freed by decrementing its reference counter. This was causing a use of memory after it was freed error. This ensures that the pointer is not accessed after it has been freed. Also moves the decrement reference counter line to the end of the function, making sure that the pointer is not accessed after it is freed.

commit 42a524b
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Fri Jan 13 04:43:29 2023 -0300

    refactor: remove old XML interface from source (opentibiabr#740)

    As it is no longer used and the code is just compiling without any need, I decided to remove the old XML system once and for all.

commit 21f7a17
Author: Karin <pessoacarlos98@gmail.com>
Date:   Thu Jan 12 21:05:33 2023 -0300

    feat: methods to set factions into player (opentibiabr#693)

    Fixed 2 players with the same factions can't attack.

    Adding 2 methods and Lua export.

    setFaction
    getFaction

commit 41a15a0
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Thu Jan 12 20:31:23 2023 -0300

    fix: blackboard description by adding 'allowDistRead' flag (opentibiabr#766)

commit cfda8a5
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Thu Jan 12 19:08:19 2023 -0300

    improve: changing concatenation to fmt::format (opentibiabr#767)

    Fixed some sonarcloud reports.

commit 6df2a92
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Thu Jan 12 12:39:44 2023 -0300

    improve: rework on Player::getStorageValue for return storage value (opentibiabr#573)

commit ccb2474
Author: Renato Foot Guimarães Costallat <costallat@hotmail.com>
Date:   Thu Jan 12 12:26:56 2023 -0300

    improve: clean and update docker (opentibiabr#716)

    Docker was not working very well, so I made a cleanup and update the Dockerfile and also the startup script to work with the current code.

    Also made some improvements to the script that docker uses to start canary.

commit d1ac9a7
Author: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Date:   Thu Jan 12 11:48:58 2023 -0300

    [Bug] fixes add skill talkaction from canary pack (opentibiabr#745)

    Fixed addskill talkaction bug

commit 3fcddfa
Author: murilo09 <78226931+murilo09@users.noreply.github.com>
Date:   Thu Jan 12 10:21:08 2023 -0300

    [Bug] forge skill chance bug by changing data type from int to double (opentibiabr#761)
luan pushed a commit that referenced this pull request Jul 11, 2023
@ElimarCosta
fix: distance weapons shouldn't hit with fists when without ammo (#755)
4be0255 
Previously, distance weapons could hit with fists even when out of ammo. This has been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murilo09 murilo09 murilo09 approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attacking with bow without ammo
4 participants
@ElimarCosta @dudantas @majestyotbr @murilo09