fix: move the styles inside the ql-toolbar to avoid style pollution

[kagol]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Style
  • Enhanced visual feedback for toolbar buttons and labels with updated hover and active states.
  • Updated color scheme for interactive elements to improve user experience.
  • Maintained styles for disabled buttons to ensure consistent appearance.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the toolbar.scss file, specifically enhancing the hover and active states of buttons and labels in the toolbar. New mixins, toolbarSvgColor and toolbarFontIconColor, have been introduced to adjust the fill color for these elements, changing it from #252b3a to #5e7ce0. The .ql-disabled class styles remain unchanged, ensuring consistency for disabled buttons. Overall, the modifications aim to improve visual feedback without altering the toolbar's layout or functionality.

Changes

File Path	Change Summary
packages/fluent-editor/src/assets/toolbar.scss	Updated hover and active styles for buttons and labels; introduced new mixins for color changes. Retained styles for .ql-disabled class.

Possibly related PRs

• fix: toolbar style update and ts error #51: This PR also modifies the toolbar.scss file, specifically addressing the styling of toolbar elements, which is directly related to the changes made in the main PR regarding hover and active states.
• fix: toolbar icon center #86: This PR enhances the styling and layout of the toolbar.scss file, focusing on button alignment and hover effects, which aligns with the visual feedback improvements made in the main PR.
• refactor: refactor font scss to eliminate duplicate code and simplify the code #94: Although primarily a refactor, this PR modifies the font.scss file, which is related to the toolbar's font styles and may indirectly connect to the overall styling changes in the toolbar as addressed in the main PR.

🐰 In the toolbar bright and blue,
Buttons dance with a vibrant hue.
Hover here, and you'll see,
Colors change so joyfully!
With every click, a cheerful sight,
Our toolbar shines, oh what delight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

packages/fluent-editor/src/assets/toolbar.scss (2)

391-401: Consider using CSS variables for color values.

The color management looks good, but consider replacing hardcoded color values with CSS variables for better maintainability and consistency:

       &:hover,
       &.ql-active {
         @include toolbarSvgColor {
-          fill: #5e7ce0;
+          fill: getCssVar(editor-primary-color, '#5e7ce0');
         }
         @include toolbarFontIconColor {
-          color: #5e7ce0;
+          color: getCssVar(editor-primary-color, '#5e7ce0');
         }
       }

---

391-413: Well-structured approach to prevent style pollution.

The use of mixins and proper nesting within .ql-toolbar effectively prevents style pollution while maintaining consistent styling behavior. The implementation follows good SCSS practices by:

1. Properly scoping styles to the toolbar component
2. Using mixins for reusable style patterns
3. Maintaining clear state management (hover, active, disabled)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 29b5c4e and 46a6ba1.

📒 Files selected for processing (1)

• packages/fluent-editor/src/assets/toolbar.scss (1 hunks)

🔇 Additional comments (1)

packages/fluent-editor/src/assets/toolbar.scss (1)

409-413: LGTM! Disabled state is properly implemented.

The disabled state styling is well-scoped and includes appropriate visual feedback with both color and cursor changes.