fix(style): list ui misplacement when direction right to left

[zzxming]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: close #197

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Style
  • Enhanced right-to-left (RTL) text support for list items in the editor
  • Improved styling for list item states in RTL mode
  • Added table styling to the editor's style context

[coderabbitai]

Walkthrough

The pull request addresses a styling issue in the FluentEditor for right-to-left (RTL) text direction. The changes are focused on the editor.scss file, specifically adding new style rules for list items with the ql-direction-rtl class. The modifications aim to resolve layout problems with numbered lists in RTL mode, ensuring proper margin and alignment for list items and their associated pseudo-elements.

Changes

File	Change Summary
packages/fluent-editor/src/assets/editor.scss	Added RTL list item styling within the editor mixin, including margin and alignment adjustments for list items in right-to-left direction

Assessment against linked issues

Objective	Addressed	Explanation
Fix RTL list item overlap [#197]	✅

Possibly related PRs

• fix: set font family doesn't effect #145: Font management modifications in the editor
• fix: move the styles inside the ql-toolbar to avoid style pollution #117: Toolbar styling updates
• fix: fix font name display wrong when config custom font toolbar close #92 #93: Font-related style restructuring
• fix(table): optimize right-click menu in table-operation-menu(#108) #140: Table operation menu optimization
• fix: align justify icon missing #165: Text justification icon addition

Suggested labels

bug

Suggested reviewers

• kagol

Poem

🐰 A rabbit's RTL delight,
Where lists now align just right,
No more overlap, no more strife,
Margins dance with coding life!
Editor's style, now crystal clear 🖋️

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b910a9b and f9ce285.

📒 Files selected for processing (1)

• packages/fluent-editor/src/assets/editor.scss (2 hunks)

🔇 Additional comments (2)

packages/fluent-editor/src/assets/editor.scss (2)

215-223: LGTM! RTL implementation looks correct.

The implementation properly addresses the RTL list misplacement by:

1. Mirroring the margins for RTL direction
2. Adjusting text alignment for proper RTL display
3. Consistently handling both list markers and checkbox UI elements

Please verify the RTL layout in different scenarios:

• Nested lists
• Mixed RTL/LTR content
• Different list types (ordered, unordered, checklist)

---

327-327: Verify table mixin's RTL compatibility.

While adding the table mixin enhances table functionality, please ensure it doesn't interfere with RTL table layouts.

Could you clarify:

1. The purpose of including the table mixin here?
2. Whether the table mixin includes RTL-specific styles?
3. If this addition is related to the RTL fix or is a separate enhancement?

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

This pull request addresses a bug fix related to the UI misplacement of list items when the text direction is set from right to left. The changes involve updating the styles in the editor.scss file to correct the alignment and spacing issues for RTL (right-to-left) list items.

Changes

File	Summary
packages/fluent-editor/src/assets/editor.scss	Added styles for li.ql-direction-rtl to adjust margins and text alignment for RTL list items.