feat(form): [form] x-design theme refresh

[gimmyhehe]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Enhanced error display for form fields, including icons and structured layouts for better visual feedback.
  • Updated URL input field label for improved presentation and styling.

• Bug Fixes

  • Improved tooltip validation to handle longer error messages effectively.

• Style

  • Introduced new styles for error messages, labels, and validation icons to enhance overall user interface consistency and responsiveness.
  • Adjusted padding and margin properties for better layout and usability in form components.

[coderabbitai]

Walkthrough

The changes encompass enhancements to the error display mechanism within a Vue.js form component, particularly for the age input field. The error messages have been restructured for better visual presentation, incorporating icons and improved layouts. Additionally, modifications to CSS styles and validation rules have been made across various files, along with updates to test cases to reflect the new error message content. Overall, the updates aim to improve the user interface and experience in handling form errors.

Changes

Files	Change Summary
examples/sites/demos/pc/app/form/error-slot-composition-api.vue	Enhanced error display for age field with structured layout and icon integration.
examples/sites/demos/pc/app/form/error-slot.spec.ts	Updated expected tooltip text for error messages in tests to reflect longer content.
examples/sites/demos/pc/app/form/error-slot.vue	Modified error template for age field and imported icon component for improved error messaging.
examples/sites/demos/pc/app/form/slot-label.vue	Updated URL input label to a custom structure with enhanced styling for better presentation.
packages/theme/src/form-item/smb-theme.js	Altered margin and height properties for form items to enhance styling consistency.
packages/theme/src/form/index.less	Added font size to tooltip validation icon for improved visual presentation.
packages/theme/src/form/vars.less	Modified padding variables for form validation to enhance spacing and layout.

Poem

🐰 In a form where errors used to hide,
A new look emerges, with icons beside.
With clearer messages, users will cheer,
A hop towards better, let’s spread the good cheer!
So let’s celebrate this change today,
For a smoother journey, hip-hip-hooray! 🎉

Tip

Announcements

• The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
• We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
• Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 47e0fb8 and fe6748a.

Files selected for processing (7)

• examples/sites/demos/pc/app/form/error-slot-composition-api.vue (3 hunks)
• examples/sites/demos/pc/app/form/error-slot.spec.ts (1 hunks)
• examples/sites/demos/pc/app/form/error-slot.vue (4 hunks)
• examples/sites/demos/pc/app/form/slot-label.vue (2 hunks)
• packages/theme/src/form-item/smb-theme.js (1 hunks)
• packages/theme/src/form/index.less (1 hunks)
• packages/theme/src/form/vars.less (1 hunks)

Files skipped from review due to trivial changes (1)

• packages/theme/src/form/index.less

Additional comments not posted (17)

examples/sites/demos/pc/app/form/error-slot.spec.ts (1)

13-15: LGTM!

The changes to the expected tooltip text enhance the test coverage by ensuring that the tooltip can handle and display longer messages correctly. The overall logic of the test remains the same, focusing on the visibility of the tooltip.

packages/theme/src/form-item/smb-theme.js (5)

3-3: LGTM!

The change to ti-form-item-margin-bottom-mini increases the margin value for the mini size form item, enhancing the spacing consistency.

---

4-4: LGTM!

The change to ti-form-item-margin-bottom-small increases the margin value for the small size form item, enhancing the spacing consistency.

---

6-6: LGTM!

The change to ti-form-item-input-mini-height updates the height value for the mini size form item input to use a CSS variable reference, improving the styling consistency and responsiveness.

---

7-8: LGTM!

The changes to ti-form-item-input-small-height and ti-form-item-input-medium-height update the height values for the small and medium size form item inputs to use a fixed pixel value and a CSS variable reference respectively, improving the styling consistency and responsiveness.

---

9-11: LGTM!

The changes to ti-form-item-mini-line-height, ti-form-item-small-line-height, and ti-form-item-medium-line-height update the line height values for the mini, small, and medium size form items to use fixed pixel values and a CSS variable reference, improving the styling consistency and responsiveness.

packages/theme/src/form/vars.less (2)

15-15: LGTM!

The change to --ti-form-valid-padding-horizontal increases the horizontal padding from 8px (plus 2px) to 16px, enhancing the spacing in the form validation component and likely improving the overall layout and usability.

---

17-17: LGTM!

The change to --ti-form-valid-padding-vertical increases the vertical padding from 8px (plus 2px) to 12px, enhancing the spacing in the form validation component and likely improving the overall layout and usability.

examples/sites/demos/pc/app/form/error-slot-composition-api.vue (3)

13-21: LGTM!

The changes to the error slot template for the age field are approved. The inclusion of an icon and a structured layout enhances the visual presentation of error messages.

---

32-34: LGTM!

The addition of the iconError import and the corresponding TinyIconError constant is approved. These changes are necessary to utilize the error icon in the error message template.

---

69-82: LGTM!

The addition of the CSS styles for the "custom-error" class is approved. These styles enhance the visual presentation of error messages by providing padding and flexbox properties for better alignment of the icon and text.

examples/sites/demos/pc/app/form/error-slot.vue (4)

13-21: LGTM!

The changes to the error slot template for the age field are approved. The inclusion of an icon and a structured layout enhances the visual presentation of error messages.

---

31-39: LGTM!

The import of the iconError component and the registration of the TinyIconError component in the components object are approved. These changes are necessary to utilize the error icon in the error message template.

---

50-54: LGTM!

The reformatting of the validation rules for the name field is approved. The changes improve the readability of the rules without altering the logic.

---

81-94: LGTM!

The addition of the CSS styles for the "custom-error" class is approved. These styles enhance the visual presentation of error messages by providing padding and flexbox properties for better alignment of the icon and text.

examples/sites/demos/pc/app/form/slot-label.vue (2)

13-15: LGTM!

The changes to the label for the URL input field are approved. The custom HTML structure allows for more complex styling and layout options, enhancing the visual presentation of the label.

---

85-93: LGTM!

The addition of the CSS styles for the .custom-label class is approved. These styles improve the user interface by providing a more sophisticated label presentation while maintaining the functionality of the form component.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.