feat(button): [button] Adapting to the SMB theme

[Youyou-smiles]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Introduced a new CSS variable for ghost button text color, enhancing theming flexibility.
  • Added hover border color for plain buttons to improve visual feedback.

• Bug Fixes

  • Updated ghost button text and hover colors for consistency, addressing potential theming issues.
  • Adjusted button sizes for small and default buttons to enhance visual consistency.

These changes refine the button styles, improving aesthetics and usability across different themes.

[coderabbitai]

Walkthrough

The changes introduce new CSS variables and modify existing ones related to button styles in the theme package. A new text color variable for ghost buttons is added, while hover states and text colors for various button types are updated to fixed color values. Additionally, modifications are made to button size specifications and test files to align with these style changes, enhancing the visual consistency and adaptability of button components across different themes.

Changes

File Path	Change Summary
packages/theme/src/button/index.less	- Added: color: var(--ti-button-ghost-text-color); in the .is-ghost class.
packages/theme/src/button/vars.less	- Added: --ti-button-plain-hover-border-color: #F5F5F5;
	- Modified: --ti-button-size-small-height: 32px; → 28px;
	- Modified: --ti-button-ghost-text-color: var(...) → #595959;
	- Modified: --ti-button-ghost-hover-text-color: var(...) → #595959;
	- Modified: --ti-button-info-ghost-hover-border-color: #FAFAFA; → #DEECFF;
examples/sites/demos/pc/app/button/dynamic-disabled.spec.ts	- Updated expected CSS properties for disabled button states.
examples/sites/demos/pc/app/button/ghost.spec.ts	- Updated expected CSS properties for various ghost buttons.
examples/sites/demos/pc/app/button/size.spec.ts	- Adjusted expected CSS height values for small and default buttons.
examples/sites/demos/pc/app/button/text.spec.ts	- Updated expected CSS color properties for specific button elements.
packages/vue/src/button/src/pc.vue	- Renamed: IconLoading: iconLoading() → IconLoading: iconLoadingShadow() in components object.

Possibly related PRs

• feat(button): [button] Adapting to the SMB theme #2079: This PR adapts the button component to the SMB theme, which is directly related to the changes made in the main PR that also focuses on button styling and theming.
• feat(button-group): [button-group] Adapting to the SMB theme #2088: This PR implements changes to the button group component to align with the SMB theme, which is relevant as it involves button-related modifications similar to those in the main PR.
• feat(button-group): [button-group] Adapting to the SMB theme #2099: This PR modifies the button group's visual representation, specifically changing the type of a button, which relates to the overall button styling and theming discussed in the main PR.

🐰 In a world of colors bright,
Buttons dance in pure delight.
Ghostly hues, a stylish flair,
With hover states that show we care.
Themes unite, a vibrant scene,
Hopping forth, our buttons gleam! ✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bd16ad4 and 73aef10.

Files selected for processing (6)

• examples/sites/demos/pc/app/button/dynamic-disabled.spec.ts (1 hunks)
• examples/sites/demos/pc/app/button/ghost.spec.ts (1 hunks)
• examples/sites/demos/pc/app/button/size.spec.ts (1 hunks)
• examples/sites/demos/pc/app/button/text.spec.ts (1 hunks)
• packages/theme/src/button/vars.less (5 hunks)
• packages/vue/src/button/src/pc.vue (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/theme/src/button/vars.less

Additional comments not posted (15)

examples/sites/demos/pc/app/button/text.spec.ts (1)

16-17: LGTM!

The changes to the expected color values for the button elements at index 2 and 4 are in line with the PR objective of adapting the button component to the SMB theme. The test case is correctly asserting the updated color properties.

examples/sites/demos/pc/app/button/size.spec.ts (2)

17-17: LGTM!

The change to the expected height of the small button from '32px' to '28px' aligns with the AI-generated summary. The test assertion has been correctly updated.

---

18-18: LGTM!

The change to the expected height of the default button from '28px' to '32px' aligns with the AI-generated summary. The test assertion has been correctly updated.

examples/sites/demos/pc/app/button/dynamic-disabled.spec.ts (4)

13-13: LGTM!

The updated background color assertion for the disabled .tiny-button element is correct and aligns with the PR objective.

---

14-14: LGTM!

The updated text color assertion for the disabled .tiny-button element is correct and aligns with the PR objective.

---

15-15: LGTM!

The updated border color assertion for the disabled .tiny-button element is correct and aligns with the PR objective.

---

19-19: LGTM!

The updated text color and border color assertions for the disabled ghostBtn element are correct and align with the PR objective.

Also applies to: 21-21

packages/vue/src/button/src/pc.vue (2)

47-47: LGTM!

The import statement change from iconLoading to iconLoadingShadow aligns with the PR objective of adapting the button component to the SMB theme. The new icon likely represents a shadow variant of the loading icon, which may affect the visual appearance of the button when in a loading state.

---

71-71: Looks good!

The component registration update for IconLoading to use the new iconLoadingShadow import is consistent with the updated import statement. This ensures that the new shadow variant of the loading icon is correctly registered and used within the component.

examples/sites/demos/pc/app/button/ghost.spec.ts (6)

11-19: LGTM!

The changes to the expected CSS properties for the primary ghost button look good. The new color values align with the overall redesign of ghost button styles mentioned in the PR summary.

---

23-31: LGTM!

The changes to the expected CSS properties for the secondary ghost button look good. The new color values align with the overall redesign of ghost button styles mentioned in the PR summary.

---

34-42: LGTM!

The changes to the expected CSS properties for the success ghost button look good. The new color values align with the overall redesign of ghost button styles mentioned in the PR summary.

---

45-53: LGTM!

The changes to the expected CSS properties for the information ghost button look good. The new color values align with the overall redesign of ghost button styles mentioned in the PR summary.

---

56-64: LGTM!

The changes to the expected CSS properties for the alert ghost button look good. The new color values align with the overall redesign of ghost button styles mentioned in the PR summary.

---

67-75: LGTM!

The changes to the expected CSS properties for the danger ghost button look good. The new color values align with the overall redesign of ghost button styles mentioned in the PR summary.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.