feat(button): [button] Modify icon button up and down centering issue

[Youyou-smiles]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Improved layout and alignment for "only icon" buttons, enhancing visual consistency.
  • Adjusted padding for icon-only buttons to eliminate extra space around icons.

• Bug Fixes

  • Ensured responsive icon sizes based on button height for better usability.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the index.less file for the button component, specifically enhancing the layout and alignment of "only icon" buttons. Key modifications include the introduction of inline-flex display properties, centering adjustments for icon alignment, and the removal of padding for the .is-only-icon class. Additionally, the handling of button sizes is updated to ensure responsive icon sizes, contributing to a more visually consistent presentation of icon-only buttons.

Changes

File Path	Change Summary
packages/theme/src/button/index.less	- Added display: inline-flex, align-items: center, and justify-content: center to .is-only-icon class. - Set padding to 0 for .is-only-icon class. - Updated icon sizing management with .size-only-icon-mixin and .size-only-icon-ontext-iconsize-mixin.

Possibly related PRs

• feat(button): [button] Adapting to the SMB theme #2104: Modifies index.less to add a new CSS variable for the .is-ghost class, affecting button styling.
• feat(button): [button] Adapting to the SMB theme #2148: Removes certain properties from the .is-only-icon class, directly relating to icon-only button layout.
• fix(button): [button]set svg size when button is only icon #2380: Introduces a new variable for icon sizing in the .is-only-icon state, enhancing functionality for icon-only buttons.
• fix(button): [button] solve the problem of uneven button graphics when mixing #2347: Modifies the .is-icon class to set its display to inline-flex and align items to the center, relevant to icon button layout improvements.

Suggested labels

enhancement

Suggested reviewers

• zzcr

🐰 In the meadow, buttons shine,
Icons centered, oh so fine.
Padding gone, they stand so tall,
A joyful change, we love them all!
Hopping forth with style and grace,
Icon buttons find their place! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/theme/src/button/index.less (1)

261-263: LGTM! The flexbox implementation effectively addresses the centering issue.

The addition of flexbox properties provides a robust solution for centering icon buttons:

• display: inline-flex maintains the button's inline behavior while enabling flex properties
• align-items: center and justify-content: center ensure perfect centering in both dimensions

Consider adding a comment to document that these properties specifically address icon centering, making it easier for future maintainers to understand the purpose:

 &.is-only-icon.is-only-icon {
+    // Use flexbox for perfect icon centering
     display: inline-flex;
     align-items: center;
     justify-content: center;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cb49210 and 5a1ba07.

📒 Files selected for processing (1)

• packages/theme/src/button/index.less (1 hunks)