fix(tabs): [tabs] Fixed the floating issue of the close button on the tab page and the style issue of the close button under the buttoncard.

[chenxi-20]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • Enhanced styling for the tabs component, including improved hover and active states.
  • Updated close icon and item separator visuals for better layout consistency.
• Bug Fixes
  • Refined conditions for displaying item separators in button card types.
• Improvements
  • Introduced CSS variables for the close icon dimensions, enhancing flexibility and responsiveness.

[coderabbitai]

Walkthrough

The changes in this pull request focus on updating the styling of the tabs component within the index.less file. Key modifications include the use of CSS variables for the close icon dimensions, adjustments to margin properties, and refined visibility conditions for item separators. Additionally, hover and active states have been enhanced to align with updated design specifications, improving responsiveness across different tab orientations. Overall, these changes aim to enhance the visual consistency and user experience of the tabs component.

Changes

File Path	Change Summary
packages/theme/src/tabs/index.less	Updated close icon dimensions to use CSS variables, adjusted margin properties, refined item separator visibility, enhanced hover and active states, and added new CSS rules for different tab orientations.

Possibly related PRs

• fix(tabs): [tabs] modify tabs demo bug #2274: This PR modifies the tabs demo, which is directly related to the changes made in the index.less file for the tabs component.
• fix(drawer): [drawer] modify the problem that the before-close method is triggered upon page loading is solved #2364: This PR focuses on the drawer component but touches on overall component behavior and visual presentation aspects relevant to the main PR.
• fix(e2e): [time-line] Fixing Test Cases #2407: This PR addresses end-to-end test cases for the timeline feature, which may share visual and functional similarities with the tabs component.

Suggested reviewers

• zzcr

🐇 In the land of tabs, where styles do play,
The close icon dances, in a flexible way.
With margins adjusted, and separators refined,
A user experience, beautifully aligned.
So hop with delight, for changes are here,
In the world of CSS, let’s give a cheer! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cb49210 and 249261a.

📒 Files selected for processing (1)

• packages/theme/src/tabs/index.less (3 hunks)

🔇 Additional comments (4)

packages/theme/src/tabs/index.less (4)

258-259: LGTM! Using CSS variables for icon dimensions.

The change to use CSS variables for close icon dimensions improves maintainability and consistency.

---

591-596: Verify if the large right margin is necessary.

While the negative left margin (-20px) helps fix the floating issue, the large right margin (24px) seems excessive.

Could you confirm if this large spacing is intentional and matches the design specifications? Consider if a smaller margin would suffice while maintaining proper spacing.

---

597-600: LGTM! Improved separator positioning.

The 1px left offset for the separator improves alignment within the button-card style.

---

1233-1234: LGTM! Logical separator visibility rules.

Good improvement to hide separators for the last child and active items, which enhances visual clarity.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.