OpenTracing Semantic Conventions uses error.object (#179)

The OpenTracing Specification suggests "error.object" as the log key for an error object. Fixes #164 Co-authored-by: Rahman Syed <rahman.syed@gmail.com>
opentracing · Apr 8, 2020 · 0dfafac · 0dfafac
1 parent 2876d20
commit 0dfafac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/log/field.go b/log/field.go
@@ -122,10 +122,10 @@ func Float64(key string, val float64) Field {
 	}
 }
 
-// Error adds an error with the key "error" to a Span.LogFields() record
+// Error adds an error with the key "error.object" to a Span.LogFields() record
 func Error(err error) Field {
 	return Field{
-		key:          "error",
+		key:          "error.object",
 		fieldType:    errorType,
 		interfaceVal: err,
 	}

diff --git a/log/field_test.go b/log/field_test.go
@@ -24,11 +24,11 @@ func TestFieldString(t *testing.T) {
 		},
 		{
 			field:    Error(fmt.Errorf("err msg")),
-			expected: "error:err msg",
+			expected: "error.object:err msg",
 		},
 		{
 			field:    Error(nil),
-			expected: "error:<nil>",
+			expected: "error.object:<nil>",
 		},
 		{
 			field:    Noop(),