Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

OpenTracing Semantic Conventions uses error.object #179

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

rahmansyed
Copy link
Contributor

The OpenTracing Specification suggests "error.object" as the log
key for an error object.

Fixes #164

The OpenTracing Specification suggests "error.object" as the log
key for an error object.

Fixes opentracing#164
@miry
Copy link

miry commented Apr 8, 2020

It seems the valid implementation of semantic. Why it is not merged?

@miry miry mentioned this pull request Apr 8, 2020
@yurishkuro yurishkuro merged commit 0dfafac into opentracing:master Apr 8, 2020
@andrewslotin
Copy link

Hi there! This turned out to be a breaking change to the libraries that depend on opentracing-go and rely on the name of the tag that carries an error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error.object or just error?
4 participants