Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Bump JaCoCo to use a Java 10 friendly version #306

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Bump JaCoCo to use a Java 10 friendly version #306

merged 1 commit into from
Sep 25, 2018

Conversation

jpkrohling
Copy link
Contributor

Before this change, building this library with a Java 10 JDK results in a failure, such as:

[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ opentracing-api ---
[INFO] Surefire report directory: /mnt/storage/jpkroehling/Projects/src/github.com/opentracing/opentracing-java/opentracing-api/target/surefire-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Exception in thread "main" java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:510)
	at java.instrument/sun.instrument.InstrumentationImpl.loadClassAndCallPremain(InstrumentationImpl.java:522)
Caused by: java.lang.RuntimeException: Class java/util/UUID could not be instrumented.
	at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:140)
	at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:101)
	at org.jacoco.agent.rt.internal_8ff85ea.PreMain.createRuntime(PreMain.java:55)
	at org.jacoco.agent.rt.internal_8ff85ea.PreMain.premain(PreMain.java:47)
	... 6 more
Caused by: java.lang.NoSuchFieldException: $jacocoAccess
	at java.base/java.lang.Class.getField(Class.java:1958)
	at org.jacoco.agent.rt.internal_8ff85ea.core.runtime.ModifiedSystemClassRuntime.createFor(ModifiedSystemClassRuntime.java:138)
	... 9 more
FATAL ERROR in native method: processing of -javaagent failed

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] OpenTracing (Parent) ............................... SUCCESS [  2.343 s]
[INFO] OpenTracing API .................................... FAILURE [  2.496 s]

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling
Bump JaCoCo to use a Java 10 friendly version
3fd39d6 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling mentioned this pull request Sep 25, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+1.02%) to 75.13% when pulling 3fd39d6 on jpkrohling:Bump-JaCoCo into d988630 on opentracing:master.

sjoerdtalsma
sjoerdtalsma approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@sjoerdtalsma sjoerdtalsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks pass, dependency bump looks ok

@pavolloffay pavolloffay merged commit 76d7b8d into opentracing:master Sep 25, 2018
tylerbenson pushed a commit to tylerbenson/opentracing-java that referenced this pull request Oct 12, 2018
@jpkrohling @tylerbenson
Bump JaCoCo to use a Java 10 friendly version (opentracing#306)
bbb0290 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
sjoerdtalsma added a commit that referenced this pull request Oct 15, 2018
@sjoerdtalsma
Set version in v0.32.0 branch to 0.32.0-SNAPSHOT (#309)
095b814 
* Bump JaCoCo to use a Java 10 friendly version (#306)

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Set version in `v0.32.0` branch to `0.32.0-SNAPSHOT`

Fixes #308
tylerbenson added a commit that referenced this pull request Dec 5, 2018
@tylerbenson
Revert "Bump JaCoCo to use a Java 10 friendly version (#306)"
4297a01 
This reverts commit 76d7b8d.
carlosalberto added a commit that referenced this pull request Mar 25, 2019
@carlosalberto
V0.32.0 (#337)
ed1925b 
* Deprecate the StringTag.set() overload taking a StringTag. (#262)
* Implement Trace Identifiers. (#280)
* Bump JaCoCo to use a Java 10 friendly version (#306)
* Remove finish span on close (#301)
  * Deprecate finishSpanOnClose on activation.
  * Add ScopeManager.activeSpan() and Tracer.activateSpan().
  * Clarify the API changes and deprecations.
  * Add an error reporting sample to opentracing-testbed.
* Simple layer on top of ByteBuffer for BINARY format. (#276)
* Add generic typed setTag/withTag (#311)
* Allow injecting into maps of type Map<String,Object> (#310)
* Add simple registerIfAbsent to global tracer (#289)
* Split Inject and Extract Builtin interfaces (#316)
* Deprecate ScopeManager.active() (#326)
* Make Tracer extends Closable. (#329)
* Do not make isRegistered() synchronized. (#333)
* Deprecate AutoFinishScopeManager (#335)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

@sjoerdtalsma sjoerdtalsma sjoerdtalsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpkrohling @coveralls @sjoerdtalsma @pavolloffay