V0.32.0 #337

carlosalberto · 2019-03-20T15:44:36Z

No description provided.

It's not a common scenario to use a Tag *key* as the tag value.

* Implement Trace Identifiers.

* Bump JaCoCo to use a Java 10 friendly version (#306) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Set version in `v0.32.0` branch to `0.32.0-SNAPSHOT` Fixes #308

* Deprecate finishSpanOnClose on activation. * Add ScopeManager.activeSpan() and Tracer.activateSpan(). * Clarify the API changes and deprecations. * Add a error reporting sample to opentracing-testbed.

* Implement a simple layer on top of ByteBuffer for BINARY format.

Reduces the need to call Tags.SOMETAG.getKey() and adds type safety for setTag if done from the span. Fixes #271

* Allow injecting into maps of type Map<String,Object> For the inject case, it doesn’t matter so much that the generic type is declared as String. * Modify generic type on map in test.

This is done so we don't end up using an abstract class in the public API.

* Add simple registerIfAbsent to global tracer

It seems the previous one expired or was discarded.

This reverts commit 3e78ba6.

If we had separate formats for inject and extract this refactor would have been much cleaner. This allows us to better avoid partially implementing the TextMap interface and throwing an exception for the other method. Since Binary is a new addition, I applied a similar refactoring to that. Closes #315.

* Deprecate ScopeManager.active() and update related code. * Rename common_request_handler to concurrent_common_request_handler. * Add a testbed case for request handlers having no storage for Scope.

* Make Tracer extends Closable.

* Update the README with the latest changes.

This one does not really need to be synchronized. The field itself is volatile and that is enough.

* Add a deprecation note for AutoFinishScopeManager/AutoFinishScope. * Add a clarification on why we are deprecating this. * Mention the Issue that lead to deprecating auto finish.

carlosalberto · 2019-03-20T16:07:47Z

Hey - created a PR prior to releasing 0.32.0 (including updating the CHANGELOG).

Let me know ;)

felixbarny · 2019-03-20T16:22:53Z

Is this release fully backwards compatible?

tylerbenson · 2019-03-20T18:14:32Z

@felixbarny It should be compatible for users, but implementations will require some changes.

carlosalberto · 2019-03-20T19:11:41Z

Hey @felixbarny yes, it's as @tylerbenson said

As an exception: for users, they will be impacted if they use inject/extract with adapters themselves, i.e.

tracer.inject(context, Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map));

to:

tracer.inject(context, Format.Builtin.TEXT_MAP_INJECT, new TextMapInjectAdapter(map)); // Or...
tracer.inject(context, Format.Builtin.TEXT_MAP, new TextMapAdapter(map));

sjoerdtalsma

Unfortunately I don't have time to go over all changes in a single go, but assuming all these are PR's that were individually reviewed already, I approve

sjoerdtalsma · 2019-03-21T07:30:48Z

CHANGELOG.md

+* Split Inject and Extract builtin interfaces.
+* `Tracer` implements `Closable`.
+* Added `GlobalTracer.registerIfAbsent()`.
+* Added `GlobalTracer.isRegistered()`.


GlobalTracer.isRegistered() already existed. The implementation changed.

Oh, right. Thanks for the review. Will update the Changelog ;)

tylerbenson · 2019-03-21T17:17:18Z

opentracing-api/pom.xml

@@ -20,7 +20,7 @@
    <parent>
        <groupId>io.opentracing</groupId>
        <artifactId>parent</artifactId>
-        <version>0.31.1-SNAPSHOT</version>
+        <version>0.32.0-RC3-SNAPSHOT</version>


Should we do an RC3?

I think we are ready for an actual release - the latest (important) change from RC2 is making Tracer implement Closable ;)

codefromthecrypt · 2019-04-02T06:26:23Z

Hey @felixbarny yes, it's as @tylerbenson said

As an exception: for users, they will be impacted if they use inject/extract with adapters themselves, i.e.
tracer.inject(context, Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map));
to:
tracer.inject(context, Format.Builtin.TEXT_MAP_INJECT, new TextMapInjectAdapter(map)); // Or...
tracer.inject(context, Format.Builtin.TEXT_MAP, new TextMapAdapter(map));

this should be added to the change log. can you do that? Also, It could be that TEXT_MAP_EXTRACT is also new? It is harder to tell without @since tags on the apis.

tylerbenson · 2019-04-02T14:15:21Z

@adriancole yes, both TEXT_MAP_INJECT and TEXT_MAP_EXTRACT were added in this release.

carlosalberto and others added 28 commits March 28, 2018 18:33

Deprecate the StringTag.set() overload taking a StringTag. (#262)

4c5dfb5

It's not a common scenario to use a Tag *key* as the tag value.

Merge branch 'master' into v0.32.0

5549c5e

Merge remote-tracking branch 'opentracing/master' into v0.32.0

d6c6509

Implement Trace Identifiers. (#280)

05e90e5

* Implement Trace Identifiers.

Set version in v0.32.0 branch to 0.32.0-SNAPSHOT (#309)

095b814

* Bump JaCoCo to use a Java 10 friendly version (#306) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Set version in `v0.32.0` branch to `0.32.0-SNAPSHOT` Fixes #308

Remove finish span on close (#301)

ac3c666

* Deprecate finishSpanOnClose on activation. * Add ScopeManager.activeSpan() and Tracer.activateSpan(). * Clarify the API changes and deprecations. * Add a error reporting sample to opentracing-testbed.

Simple layer on top of ByteBuffer for BINARY format. (#276)

9202384

* Implement a simple layer on top of ByteBuffer for BINARY format.

Add generic typed setTag/withTag (#311)

bffd9b6

Reduces the need to call Tags.SOMETAG.getKey() and adds type safety for setTag if done from the span. Fixes #271

Allow injecting into maps of type Map<String,Object> (#310)

b6f6324

* Allow injecting into maps of type Map<String,Object> For the inject case, it doesn’t matter so much that the generic type is declared as String. * Modify generic type on map in test.

Use Tag<T> instead of AbstractTag<T> for Span.setTag().

9b6ca36

This is done so we don't end up using an abstract class in the public API.

Add simple registerIfAbsent to global tracer (#289)

013dafb

* Add simple registerIfAbsent to global tracer

Update our GH_TOKEN for Travis.

aa1a5d2

It seems the previous one expired or was discarded.

[maven-release-plugin] prepare release 0.32.0-RC1

ceef45d

[maven-release-plugin] prepare for next development iteration

d6f60dd

Revert "Add service tag (#287)" (#322)

11bf4f5

This reverts commit 3e78ba6.

Merge branch 'master' into v0.32.0

e7ef15c

Merge branch 'master' into v0.32.0

e977cc3

Update the copyright year for some remaining files.

a0b972e

Deprecate ScopeManager.active() (#326)

323f9db

* Deprecate ScopeManager.active() and update related code. * Rename common_request_handler to concurrent_common_request_handler. * Add a testbed case for request handlers having no storage for Scope.

[maven-release-plugin] prepare release 0.32.0-RC2

33f5484

[maven-release-plugin] prepare for next development iteration

748a229

Make Tracer extends Closable. (#329)

8176208

* Make Tracer extends Closable.

V0.32.0 README update (#332)

7010904

* Update the README with the latest changes.

Do not make isRegistered() synchronized. (#333)

e2f9280

This one does not really need to be synchronized. The field itself is volatile and that is enough.

Deprecate AutoFinishScopeManager (#335)

1fb24fd

* Add a deprecation note for AutoFinishScopeManager/AutoFinishScope. * Add a clarification on why we are deprecating this. * Mention the Issue that lead to deprecating auto finish.

Merge branch 'master' into v0.32.0

916bf13

Update CHANGELOG.

1a7bb25

carlosalberto requested a review from yurishkuro March 20, 2019 16:07

carlosalberto requested review from sjoerdtalsma and jpkrohling March 20, 2019 16:09

sjoerdtalsma approved these changes Mar 21, 2019

View reviewed changes

tylerbenson reviewed Mar 21, 2019

View reviewed changes

tylerbenson approved these changes Mar 22, 2019

View reviewed changes

Remove GlobalTracer.isRegistered() from the CHANGELOG.

725ca7f

carlosalberto merged commit ed1925b into master Mar 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V0.32.0 #337

V0.32.0 #337

carlosalberto commented Mar 20, 2019

carlosalberto commented Mar 20, 2019

felixbarny commented Mar 20, 2019

tylerbenson commented Mar 20, 2019

carlosalberto commented Mar 20, 2019

sjoerdtalsma left a comment

sjoerdtalsma Mar 21, 2019

carlosalberto Mar 21, 2019

tylerbenson Mar 21, 2019

carlosalberto Mar 21, 2019

codefromthecrypt commented Apr 2, 2019

tylerbenson commented Apr 2, 2019

V0.32.0 #337

V0.32.0 #337

Conversation

carlosalberto commented Mar 20, 2019

carlosalberto commented Mar 20, 2019

felixbarny commented Mar 20, 2019

tylerbenson commented Mar 20, 2019

carlosalberto commented Mar 20, 2019

sjoerdtalsma left a comment

Choose a reason for hiding this comment

sjoerdtalsma Mar 21, 2019

Choose a reason for hiding this comment

carlosalberto Mar 21, 2019

Choose a reason for hiding this comment

tylerbenson Mar 21, 2019

Choose a reason for hiding this comment

carlosalberto Mar 21, 2019

Choose a reason for hiding this comment

codefromthecrypt commented Apr 2, 2019

tylerbenson commented Apr 2, 2019