Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Revert PR 287 which added service tag #322

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Revert PR 287 which added service tag #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions opentracing-api/src/main/java/io/opentracing/tag/Tags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,6 @@ private Tags() {
*/
public static final String SPAN_KIND_CONSUMER = "consumer";

/**
* The service name for a span, which overrides any default "service name" property defined
* in a tracer's config. This tag is meant to only be used when a tracer is reporting spans
* on behalf of another service (for example, a service mesh reporting on behalf of the services
* it is proxying). This tag does not need to be used when reporting spans for the service the
* tracer is running in.
*
* @see #PEER_SERVICE
*/
public static final StringTag SERVICE = new StringTag("service");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't this be deprecated instead of removed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 here. This would be breaking things.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag was not present in 0.31.0, so this would only be a breaking change for someone using a unofficial build. That is the main reason I'm pushing to get it removed before 0.32.0 so it doesn't have to go through a deprecation period.


/**
* HTTP_URL records the url of the incoming request.
*/
Expand All @@ -82,9 +71,7 @@ private Tags() {
public static final StringTag PEER_HOST_IPV6 = new StringTag("peer.ipv6");

/**
* PEER_SERVICE records the service name of the peer service.
*
* @see #SERVICE
* PEER_SERVICE records the service name of the peer.
*/
public static final StringTag PEER_SERVICE = new StringTag("peer.service");

Expand Down