-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[popup] Display Ordering: will this cause open="" attributes to get removed during HTML parsing? #494
Comments
@annevk said: Note that custom elements don't end up executing script in all documents they end up in, e.g., with |
Note that the updated explainer removes the |
(FWIW, I think |
How does this work in the case of slow-loading pages? E.g. <popup initiallyopen>...</popup>
<!-- network stalls for 2 seconds -->
<popup initiallyopen>...</popup>
<!-- network stalls for 2 seconds -->
<popup initiallyopen>...</popup>
<!-- network stalls for 10 seconds --> |
The
Yep, this is an excellent point. I guess that puts us back to actually opening and closing each Based on the above comments, I'm inclined to close this issue. Feel free to re-open if you disagree. |
Filed #500. |
Coming back to this closed issue: I forgot one key detail in the above discussion. For |
This PR fixes the text around the ordering of `initiallyopen`, stating that only the **first** popup will be shown, rather than the last. See [this comment](openui#494 (comment)).
This PR fixes the text around the ordering of `initiallyopen`, stating that only the **first** popup will be shown, rather than the last. See [this comment](#494 (comment)). Co-authored-by: Mason Freed <masonf@chromium.org>
This issue was reported by @domenic here, and is being moved to the OpenUI repo.
https://github.com/mfreed7/popup#display-ordering
The implication of this, combined with https://github.com/mfreed7/popup#dismiss-behavior, is that at the end of parsing only a single
open=""
attribute will be present, and others will be removed.If this is the case, it'd be good to call it out explicitly. Also, there is some worry about modifications to the DOM during parsing, and the associated events; see whatwg/html#4500 /cc @annevk @emilio. But probably it's no worse than custom elements, so I think that's not a real issue, just something we need to step lightly around...
The text was updated successfully, but these errors were encountered: