-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[popup] Consider renaming initiallyopen #500
Comments
The Open UI Community Group just discussed The full IRC log of that discussion<hdv> Topic: [popup] Consider renaming initiallyopen#500<hdv> github: https://github.com//issues/500 <JonathanNeal> q+ <una> q+ <hdv> masonf: we could talk about 500 or 508 actually <JonathanNeal> my question is whether these attributes can be considered strictly initial values or living values? <scotto> +1 to mason's suggestion <hdv> Travis: does anyone have a suggestion or strong feeling on issue 500? <hdv> q? <flackr> q+ <hdv> ack una <flackr> q- <flackr> q+ to question why not open instead of initiallyopen <hdv> JonathanNeal: are the values the initial states like in inputs? are they attributes that change when you change them in DOM they also change? are they strictly serialised or do they change? <hdv> flackr: I don't know why we decided it couldn't be open, we have existing behavior for checked and others <hdv> bkardell_: isn't it because open in another place in the DOM means the opposite <hdv> masonf: yes that's why, it is confusing in two ways, one reason being that 'open' only has affect first time, like initially, not after that… the other discussion is whether that attribute would be live <JonathanNeal> I think knowing whether these are initial or live by default is key to bike-shedding, for me. <masonf> q? <hdv> q? <Travis> q? <hdv> ack JonathanNeal <hdv> ack flackr <Zakim> flackr, you wanted to question why not open instead of initiallyopen <hdv> masonf: for initiallyOpen things would be a lot easier <hdv> bkardell_: I wanted to ask because we have dbaron and Travis here… I know we have relationships through TAG / former TAG… I remember there being guidance around such things, so I would be curious about your thoughts <JonathanNeal> q+ <hdv> dbaron: TAG guidance on naming has some general things, but I can't think of anything that is specifically applicable here… one thing is that it discusses values like true and false, can't think of anything that would apply to initiallyOpen or triggerPopup <hdv> bkardell_: is it worth inventing a policy for new attributes? <hdv> bkardell_: like when is something a live, reflective value? <JonathanNeal> With the exception of new elements like <details>, are live reflected values generally not a thing? <hdv> Travis: if there's not already an issue that may be worth raising… what are cases? <hdv> masonf: <dialog> has a live open attribute <JonathanNeal> I can only think of maybe <details> or <dialog> and I am wondering if those are examples we should follow or avoid following. <JonathanNeal> I would be in favor of not following those two elements. <hdv> scotto: and <details> element also has it. but it pushes its state down to <summary> <hdv> masonf: we've moved in the direction of CSS pseudo state for stating whether it is open or not, it would remove a lot of problems <hdv> Travis: in that case I kind of trend towards the default state <JonathanNeal> With that resolution about the CSS pseudo-state, I would be even more strongly in favor of the attribute reflecting the initial state. <JonathanNeal> e.g. `open` boolean <masonf> q? <hdv> s/the default state/how masonf presented it earlier <Travis> q? <bkardell_> https://github.com/w3ctag/design-principles/issues/289 is one of the related issues in tag |
I would like to throw a vote in here for being explicit in the naming and working through discussion on this TAG issue and #311 to determine something that at least the rest of the OpenUI proposals that have a similar case can follow - in other words Personally, I kind of lean toward @annevk and @domenic's comments that thread |
I think a potentially confusing thing with |
I'm agnostic between |
I'm not saying the What I am saying is that because However, it's possible that most developers never use |
In my own experience, developers using React are very familiar with the
For compatibility reasons, I am uncertain which path breaks less expectations. I am not outright opposed to a EDIT: Upon further consideration, I am generally in favor of Also, thank you for the helpful resources, @bkardell. I have been considering this thought experiment:
My issue with that thought experiment is context. If I copy a form, then I may or may not want the input fields to include their content. The same for whether a popup is open. I might expect something completely different depending on whether I’m copying the content for printing or copying the content for another content editor. I tend to prefer reflecting state in DOM and CSS properties, and not in HTML attributes / forced mutations. |
Ahh, I see your point. Ok, sounds like something to consider. Thanks for pointing out w3ctag/design-principles#279 and w3ctag/design-principles#289 - some interesting reading there. The only hard conclusions seem to be that the IDL and content attributes should have the same name, and should stay in sync. As that relates to this issue (about
Again, I'm relatively agnostic. I'm hearing more votes for |
Note that "default" in the context of form controls also denotes that it's the value that resetting the form will reset the control to. I.e. it's not just on the page load. I'm not sure if that has any bearing on non-form-control cases, but just something to consider. |
Yep, good point. But as you said - I don't think that part applies to a popup element. I'm not sure if that adds confusion or doesn't change things at all. Is your vote for |
I think I'm agnostic. I like |
I apologize if I am conflating things, but it seem like there could be a lot of these initial/default values, at least between details, dialog, popup, and a tabs effort that I’m working on. From my point of view, it seems like it would be very confusing to remember and manage these (semi?) global attributes across a document without a central, consistent pattern. Would there be interest in “punting” on these individual attributes in exchange for a singular, consistent pattern that could assign multiple kinds of initial/default values going forward? Without explicitly recommending an implementation, could we have a universal |
While Imagine we introduced a new version of iframe which used that concept - it has to be provided an default value, and you can't change it. I'm not sure why we'd do that, and I'm not suggesting we should - I just needed an attribute to show what I mean: |
This seems tough, since the meaning of the thing being "defaulted" differs between things, and the syntax will be interesting. I'm not against trying to make this better, but I'd really like to avoid tying the Popup API to this effort. Would it be ok to work on this separately, and then apply it to Popup along with the rest of the things?
This was a really convincing argument for me. I agree that |
There are various HTML attributes with "initially" semantics but without any prefix (e.g. |
Fair point. But I don't know how the community sees those other attributes with "default" semantics but without a prefix - are those good? I personally find them confusing, especially That's really beside the point I guess, since those are shipped. Do you think |
If we plan to replace
Yes. |
Wow - bold plan. I like it. But it might take decades. 😄
Which question exactly are you interested in polling about?
Thanks! |
|
The Open UI Community Group just discussed
The full IRC log of that discussion<hdv> Topic: [popup] Consider renaming initiallyopen #500<hdv> github: https://github.com//issues/500 <JonathanNeal> q? <hdv> masonf: this issue is bikeshedding renaming the initiallyopen attribute <hdv> masonf: looks from my reading that there is consensus for changing to defaultopen <jh3y> `defaultopen` +1 <scotto> +1 <bkardell_> +1 <masonf> Proposed resolution: Rename `initiallyopen` to `defaultopen`. <JonathanNeal> q? <hdv> masonf: so proposed resolution would be to rename initiallyopen to defaultopen <jh3y> Matches framework usage too +1 <flackr> +1 <hdv> scotto: in HTML-AAM we are defining some stuff to default to align with existing stuff, that's my reason to +1 as it would be easir <hdv> s/easir/easier <JonathanNeal> q? <masonf> RESOLVED: Rename `initiallyopen` to `defaultopen`. |
as mentioned in the call today, HTML AAM is purposefully using the term 'default' in some updates we're doing now / will be doing in the future rather than using the term 'initial' or 'initially' see w3c/html-aam#396 |
Per the resolution, I'm closing this issue. |
See the resolution below, but we've decided that `defaultopen` is a better name for this feature. No functional changes. openui/open-ui#500 Bug: 1307772 Change-Id: I9e11739a34d5180df889c9f93622bbddbd9bf982
See the resolution below, but we've decided that `defaultopen` is a better name for this feature. No functional changes. openui/open-ui#500 Bug: 1307772 Change-Id: I9e11739a34d5180df889c9f93622bbddbd9bf982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615796 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#997905}
See the resolution below, but we've decided that `defaultopen` is a better name for this feature. No functional changes. openui/open-ui#500 Bug: 1307772 Change-Id: I9e11739a34d5180df889c9f93622bbddbd9bf982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615796 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#997905}
See the resolution below, but we've decided that `defaultopen` is a better name for this feature. No functional changes. openui/open-ui#500 Bug: 1307772 Change-Id: I9e11739a34d5180df889c9f93622bbddbd9bf982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615796 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#997905}
…popup, a=testonly Automatic update from web-platform-tests Rename initiallyopen to defaultopen for popup See the resolution below, but we've decided that `defaultopen` is a better name for this feature. No functional changes. openui/open-ui#500 Bug: 1307772 Change-Id: I9e11739a34d5180df889c9f93622bbddbd9bf982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615796 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#997905} -- wpt-commits: 06c581ae1cf8a316114f5013579bbed1dc72603b wpt-pr: 33876
…popup, a=testonly Automatic update from web-platform-tests Rename initiallyopen to defaultopen for popup See the resolution below, but we've decided that `defaultopen` is a better name for this feature. No functional changes. openui/open-ui#500 Bug: 1307772 Change-Id: I9e11739a34d5180df889c9f93622bbddbd9bf982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615796 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#997905} -- wpt-commits: 06c581ae1cf8a316114f5013579bbed1dc72603b wpt-pr: 33876
See the resolution below, but we've decided that `defaultopen` is a better name for this feature. No functional changes. openui/open-ui#500 Bug: 1307772 Change-Id: I9e11739a34d5180df889c9f93622bbddbd9bf982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615796 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#997905} NOKEYCHECK=True GitOrigin-RevId: 9222b44127c7570b17204d5a8f90558b5cc85ad3
As expressed by @zcorpan at #311 (comment) I think this should have an easier name, e.g.,
defaultopen
.It seems @domenic did not care strongly and apart from @mfreed7 I could not find anyone else who chimed in on the name, but maybe I missed something?
The text was updated successfully, but these errors were encountered: