Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Protect ov::Exception constructor #22680

Merged
merged 9 commits into from
Feb 8, 2024
Merged

[Core] Protect ov::Exception constructor #22680

merged 9 commits into from
Feb 8, 2024

Conversation

t-jankowski
Copy link
Contributor

@t-jankowski t-jankowski commented Feb 6, 2024 •
edited
Loading

Details:

  • Changes ov::Exception(const std::string&) constructor access from public to protected.

Tickets:

@t-jankowski t-jankowski requested review from a team as code owners February 6, 2024 11:39
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: AUTO OpenVINO AUTO device selection plugin category: CPP API OpenVINO CPP API bindings labels Feb 6, 2024
@t-jankowski t-jankowski added this to the 2024.0 milestone Feb 6, 2024
@p-durandin
Copy link
Contributor

@t-jankowski please update contrib: /__w/openvino/openvino/openvino_contrib/modules/nvidia_plugin/src/error.cpp
@ilya-lavrenov FYI

@t-jankowski t-jankowski mentioned this pull request Feb 7, 2024
Merged
@p-durandin
Copy link
Contributor

@t-jankowski please make PR to NPU repo
./../repos/applications.ai.vpu-accelerators.vpux-plugin/src/vpux_al/src/sync_infer_request.cpp:117:5: error: no matching function for call to ‘ov::NotImplemented::create(const char [39], int, const char [6], const char [1], std::__cxx11::basic_ostringstream::__string_type)’

@ilya-lavrenov ilya-lavrenov self-assigned this Feb 7, 2024
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Feb 8, 2024
Merged via the queue into openvinotoolkit:master with commit a090338 Feb 8, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz approved these changes

@vurusovs vurusovs vurusovs approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: AUTO OpenVINO AUTO device selection plugin category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings Code Freeze
Projects
None yet
Milestone
2024.0
Development

Successfully merging this pull request may close these issues.
5 participants
@t-jankowski @p-durandin @ilya-lavrenov @vurusovs @praasz