Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NVIDIA] Add ov::Exception wrapper #869

Conversation

t-jankowski
Copy link
Contributor

Add ov::Exception wrapper to access its protected constructor.

to access its protected constructor
@t-jankowski t-jankowski requested a review from a team as a code owner February 7, 2024 09:48
@github-actions github-actions bot added the category: NVIDIA plugin OpenVINO NVIDIA plugin label Feb 7, 2024
@p-durandin
Copy link
Contributor

build_jenkins

@t-jankowski
Copy link
Contributor Author

Blocks openvinotoolkit/openvino#22680

@@ -20,7 +25,7 @@ template <typename T>

[[gnu::cold, noreturn]] void throw_ov_exception(const std::string& msg,
const std::experimental::source_location& location) {
throw_exception<ov::Exception>(msg, location);
throw_exception<OVExceptionWrapper>(msg, location);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could create specialization of this throw_exception which throws via Exception::create

@ilya-lavrenov ilya-lavrenov merged commit d219e31 into openvinotoolkit:master Feb 7, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: NVIDIA plugin OpenVINO NVIDIA plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants