-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor names/folders/objects for better verbosity #5
Refactor names/folders/objects for better verbosity #5
Conversation
To discuss @negvet @goodsong81 openvino_xai. Rename to be more concise? xai_branch_inserter | xai_inserter | inserter | xai_ir_inserter |
We need to have consistency between 3 options of calling Method, Task:
I personally like both 2 and 3 option equally. |
Assuming that one of this refactoring objective is to make code to be more concise, I would vote for the |
I would propose for the code under openvino_xai to be follow option 3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the prompt renaming!
Looks good in general. I'd like to request a few minor changes.
Please review my comments.
p.s. Ah, please don't forget to update the license notices. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update!
Methods/Objects:
TaskType
- > task=Task
XAIMethodType
.RECIPROCAM -> explain_method=Method
.RECIPROCAMExplanationResult
->Explanation
PostProcessParameters
-> visualization_parameters=VisualizationParameters
PostProcessor
->Visualizer
sal_map_shape
-> explanation.shape
SaliencyMapLayout
-> openvino_xai.explainer.explanation.py:Layout
openvino_xai.Method
andopenvino_xai.Task
import openvino_xai as xai ... xai.Task, xai.Method
for external usageimport openvino_xai as xai ... xai.Explainer
for external usageFiles/Folders:
openvino.xai
explain
->explainer
explanation_parameters
->parameters
visualize
->visualizer
algorithms
->methods
insertion
->inserter
insertion_parameters
->parameters
Added 2024 year in LICENSE