Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XAI Method Abstract Interface #7

Merged
merged 13 commits into from
Jun 10, 2024
Merged

Support XAI Method Abstract Interface #7

merged 13 commits into from
Jun 10, 2024

Conversation

negvet
Copy link
Collaborator

@negvet negvet commented Jun 6, 2024 •
edited
Loading

Support XAI Method Abstract Interface

@negvet negvet marked this pull request as ready for review June 7, 2024 13:38
GalyaZalesskaya
GalyaZalesskaya reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a great work, left a few minor comments

examples/run_classification.py Outdated Show resolved Hide resolved
openvino_xai/explainer/explainer.py Outdated Show resolved Hide resolved
openvino_xai/explainer/explainer.py Show resolved Hide resolved
goodsong81
goodsong81 reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work. Looks good in general.
Please review my minor suggestions and feel free to accept or not ;p

openvino_xai/methods/create_method.py Outdated Show resolved Hide resolved
GETTING_STARTED.ipynb Show resolved Hide resolved
docs/Usage.md Outdated Show resolved Hide resolved
examples/run_classification.py Outdated Show resolved Hide resolved
openvino_xai/explainer/explainer.py Outdated Show resolved Hide resolved
openvino_xai/explainer/explainer.py Outdated Show resolved Hide resolved
openvino_xai/inserter/inserter.py Outdated Show resolved Hide resolved
openvino_xai/methods/base.py Show resolved Hide resolved
openvino_xai/methods/base.py Outdated Show resolved Hide resolved
GalyaZalesskaya
GalyaZalesskaya previously approved these changes Jun 10, 2024
View reviewed changes
openvino_xai/explainer/parameters.py Outdated Show resolved Hide resolved
@negvet negvet enabled auto-merge (squash) June 10, 2024 15:07
@negvet negvet merged commit 262b82b into openvinotoolkit:develop Jun 10, 2024
4 checks passed
@goodsong81 goodsong81 added this to the 1.0.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalyaZalesskaya GalyaZalesskaya GalyaZalesskaya approved these changes

@goodsong81 goodsong81 Awaiting requested review from goodsong81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@negvet @goodsong81 @GalyaZalesskaya