Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/OTX] Rebase develop to feature/otx before MPA refactoring #1284

Merged
merged 48 commits into from
Sep 26, 2022

Conversation

harimkang
Copy link
Contributor

Summary

This is to rebase the current develop branch to feature/otx before MPA refactoring (This excludes external/anomaly)

This PR includes :

  • Rebase develop -> feature/otx
  • Exclude external/anomaly

ashwinvaidya17 and others added 30 commits August 24, 2022 09:02
* Update multi-label classification templates

* Change default from multi-class to multi-label
[CVS-89912] Fixed config path computation
* Remove initialize from export functions

* self._precision to FP32

* Update export initialize

* Task changes
Co-authored-by: Lee, Soobee <soobeele@intel.com>
* Add @attr decorator for base configs
* Update config.py
* Fix import

Signed-off-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Harim Kang <harim.kang@intel.com>
[Anomaly Task] Change OpenVINO MO Command
…-train-failure

Fix CVS-90509 Semantic segmentation training with all templates doesn't work in cpu.
…icense-file-in-exportable-code

Ludo/cvs 90428 update license file in exportable code
* Move configuration.yaml and associated files to tempates folder.

* Revert to old configuration format + fix save model issue

* Update nncf compression_config.json path

* Disable editable in pruning_supported

* Remove copy

* Move algorithm/configuration.py to base
* Address progress issue for HPO callback

* Merge hpo and progress callback as only one progress callback is supported
supersoob and others added 9 commits September 15, 2022 18:29
Propagate changes from the 1.2 release branch (RC1) to develop
* Remove (Change to skip) some model template test cases for OTE-CI test (some external backend's API & performance tests)

* Fixed some library version conflict issue (in OTE CI venv)

* Fixed some test cases not working (MPA ote_cli tests)

* Add MPA pre-commit tests (not for pydocstyle -> will check it out later)

* Resolve prettier issue (data/car_tree_bug/annotations/hierarchical_default.json)

* Resolve black issue (ote_cli/ote_cli/utils/hpo.py)


Co-authored-by: Jihwan Eom <jihwan.eom@intel.com>
* conftest Import Error Fix

* Validation Report Selection fix

* Change Name TestClass for resolving file name too long issue

* Fix Anomaly template root path
* flake8 & black check

* Enable black to mpa_tasks

* Modify flake8 issue in mpa_tasks

* README update & skip algo_table check test

* Change test_docs::test_algorithms_table

* Fix some codes

* Temporaly disable mpa mypy

* Resolve pylint issues

* Rebase develop

* Resolve new develop commit's pre-commit issues

* Remove duplicated code in config

* MPA commit update

* Update TT_STABILITY_TEST

* Update anomaly ote_cli test for TT_STABILITY_TEST

* Rename TT_STABILITY_TEST to TT_STABILITY_TESTS
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM API Any changes in OTX API ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Sep 26, 2022
@harimkang harimkang changed the title [Feature/OTX] Rebase develop to feature/otx for MPA refactoring [Feature/OTX] Rebase develop to feature/otx before MPA refactoring Sep 26, 2022
@harimkang
Copy link
Contributor Author

harimkang commented Sep 26, 2022

@ashwinvaidya17 Hi, Before starting the MPA task refactoring in feature/otx, I first reflected the changes in the develop branch. However, I have excluded the changes in the external/anomaly folder for now. Because I wasn't sure exactly what changes should be reflected here. With this in mind, take a look at the code. (And please let me know if I'm missing anything)

And, as I recall, we set the number of character limits in the code to 120. However, Codacy-Static-Code-Analysis (CSCA) is still checking based on 80 characters. Do you have any idea how to solve this? Currently, CSCA is in Fail status, but this is confirmed by the content related to the number of characters in quick_guide doc.

@harimkang harimkang marked this pull request as ready for review September 26, 2022 07:34
@harimkang harimkang requested a review from a team as a code owner September 26, 2022 07:34
@samet-akcay
Copy link
Contributor

@harimkang, thanks for creating this PR.

I see that there are some changes in ote_sdk. These changes should also be added to otx.api. Otherwise, it would be hard to sync the changes between ote_sdk and otx.api.

Would you be able to add those changes to the corresponding location in otx.api?

@harimkang
Copy link
Contributor Author

@harimkang, thanks for creating this PR.

I see that there are some changes in ote_sdk. These changes should also be added to otx.api. Otherwise, it would be hard to sync the changes between ote_sdk and otx.api.

Would you be able to add those changes to the corresponding location in otx.api?

Hi @samet-akcay, Yes, I will look into it (ote_sdk & otx.api) and reflect on it.

@samet-akcay
Copy link
Contributor

And, as I recall, we set the number of character limits in the code to 120. However, Codacy-Static-Code-Analysis (CSCA) is still checking based on 80 characters. Do you have any idea how to solve this? Currently, CSCA is in Fail status, but this is confirmed by the content related to the number of characters in quick_guide doc.

This is because Codacy complains about the markdown file. We set the line length to 120 for the .py files, but not .md files. You could ignore that for now. We'll address that later.

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harimkang

@harimkang harimkang merged commit caf7492 into feature/otx Sep 26, 2022
@harimkang harimkang deleted the feature/harim/otx branch September 26, 2022 11:19
yunchu pushed a commit that referenced this pull request Nov 8, 2022
…1284)

* Update submodule branch (#1222)

* Enhance training schedule for multi-label classification (#1212)

* [CVS-88098] Remove initialize from export functions (#1226)

* Train graph added (#1211)

Co-authored-by: Lee, Soobee <soobeele@intel.com>

* Add @attrs decorator for base configs (#1229)

Signed-off-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Harim Kang <harim.kang@intel.com>

* Pretrained weight download error in MobilenetV3-large-1 of deep-object-reid in SC (#1233)

* [Anomaly Task] Revert hpo template (#1230)

* 🐞 [Anomaly Task] Fix progress bar (#1223)

* [CVS-90555] Fix NaN value in classification (#1244)

* update hpo_config.yaml (#1240)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* Turned off pruning_support visibility for anomaly models (CVS-91015)

* Disabled pruning for EfficientNet-V2-S (CVS-90400)

* [Anomaly Task] 🐞 Fix inference when model backbone changes (#1242)

* Fix CVS-91469 sseg compatibility issue

* [CVS-91472] Add pruning_supported value (#1263)

* Pruning supported tweaks (#1256)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* Turned off pruning_support visibility for anomaly models (CVS-91015)

* Disabled pruning for EfficientNet-V2-S (CVS-90400)

* Revert "[CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)" (#1269)

* [OTE-TEST] Disable obsolete test cases (#1220)

* [OTE-TEST] hot-fix for MPA performance tests (#1273)

* Expose early stopping hyper-parameters for all tasks (#1241)

* Resolve pre-commit issues (#1272)

* Remove LazyEarlyStopHook in model_multilabel.py (#1281)

* Removed xfail (#1239)

Signed-off-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com>
Co-authored-by: Nikita Savelyev <nikita.savelyev@intel.com>
Co-authored-by: Vladisalv Sovrasov <sovrasov.vlad@gmail.com>
Co-authored-by: Jihwan Eom <jihwan.eom@intel.com>
Co-authored-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Soobee Lee <soobee.lee@intel.com>
Co-authored-by: Lee, Soobee <soobeele@intel.com>
Co-authored-by: Eugene Liu <eugene.liu@intel.com>
Co-authored-by: Emily Chun <emily.chun@intel.com>
Co-authored-by: ljcornel <ludo.cornelissen@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.