[FIX] Arrange scale between bbox preds and bbox targets in ATSS #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunwoosh
reviewed
Mar 14, 2023
eunwoosh
approved these changes
Mar 14, 2023
sungmanc
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Could you follow the PR template?
e.g. openvinotoolkit/datumaro#854
|
Isn't same bugfix needed to release branch? |
goodsong81
requested changes
Mar 14, 2023
goodsong81
approved these changes
Mar 14, 2023
goodsong81
pushed a commit
that referenced
this pull request
Mar 14, 2023
Arrange scale between bbox preds and bbox targets
goodsong81
added a commit
that referenced
this pull request
Mar 14, 2023
* Fix ote_config -> otx_config * [FIX] hang issue when tracing a stack in certain scenario (#1868) fix: use primitive library * [FIX][POT] Set stat_requests_number parameter to 1 (#1870) Set POT stat_requests_number parameter to 1 in order to lower RAM footprint * [FIX] Training error when batch size is 1 (#1872) fix: drop last batch * Recover detection num_workers=2 * Remove nbmake from base requirements * Add py.typed in package * [FIX] Arrange scale between bbox preds and bbox targets in ATSS (#1880) Arrange scale between bbox preds and bbox targets --------- Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com> Co-authored-by: Nikita Savelyev <nikita.savelyev@intel.com> Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com>
goodsong81
added a commit
that referenced
this pull request
Mar 17, 2023
* [RELEASE][DOC] Fix wrong info in documentation (#1849) * updated dataset formats info. Fix for multilabel classification * revert file * revert file. minor * added warning to instance segmentation * revert changes * [Enhance] Separate installation for each tasks on release task (#1869) * separte_import * align with pre commit * update unit test code * add separate task env pre merge test & aplly it to github action * add multiprocess to requirement * [FIX][REL1.0] Fix Geti integration issues (#1885) * Fix ote_config -> otx_config * [FIX] hang issue when tracing a stack in certain scenario (#1868) fix: use primitive library * [FIX][POT] Set stat_requests_number parameter to 1 (#1870) Set POT stat_requests_number parameter to 1 in order to lower RAM footprint * [FIX] Training error when batch size is 1 (#1872) fix: drop last batch * Recover detection num_workers=2 * Remove nbmake from base requirements * Add py.typed in package * [FIX] Arrange scale between bbox preds and bbox targets in ATSS (#1880) Arrange scale between bbox preds and bbox targets * [FIX][RELEASE1.0] Remove cfg dump in ckpt (#1895) * Remove cfg dump in ckpt * Fix pre-commit * Release v1.0.1 * [FIX] Prevent torch 2.0.0 installation (#1896) * Add torchvision & torchtext in requirements/anomaly.txt with fixed version * Update requirements/anomaly.txt * Fix _model_cfg -> _recipe_cfg due to cfg merge --------- Signed-off-by: Songki Choi <songki.choi@intel.com> Co-authored-by: Prokofiev Kirill <kirill.prokofiev@intel.com> Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com> Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com> Co-authored-by: Nikita Savelyev <nikita.savelyev@intel.com> Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com> Co-authored-by: Jihwan Eom <jihwan.eom@intel.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause
Bbox encode or decode status is not matched between bbox preds and bbox targets in ATSS
Solution
Check self.reg_decoded_bbox value. If self.reg_decoded_bbox is True, then ATSS has to decode bbox_pred values since bbox_target values are not encoded