Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][RELEASE1.0] Remove cfg dump in ckpt #1895

Merged

Conversation

goodsong81
Copy link
Contributor

Summary

  • Injected progress hook from Geti results in pickling error as we put the callback in MMCV cfg
  • Removed MMCV cfg from model ckpt dump

How to test

  • Normal CI tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 requested a review from a team as a code owner March 16, 2023 12:00
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Mar 16, 2023
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81
Copy link
Contributor Author

Unit tests have passed but coverage upload keeps failing.
Integration tests are all green on local tests.
image

@goodsong81 goodsong81 merged commit fcb3293 into openvinotoolkit:releases/v1.0.0 Mar 17, 2023
@goodsong81 goodsong81 deleted the songkich/fix-pickle branch March 17, 2023 04:45
goodsong81 added a commit that referenced this pull request Mar 17, 2023
* [RELEASE][DOC] Fix wrong info in documentation (#1849)
* updated dataset formats info. Fix for multilabel classification
* revert file
* revert file. minor
* added warning to instance segmentation
* revert changes

* [Enhance] Separate installation for each tasks on release task (#1869)
* separte_import
* align with pre commit
* update unit test code
* add separate task env pre  merge test & aplly it to github action
* add multiprocess to requirement

* [FIX][REL1.0] Fix Geti integration issues (#1885)
* Fix ote_config -> otx_config

* [FIX] hang issue when tracing a stack in certain scenario (#1868)
fix: use primitive library

* [FIX][POT] Set stat_requests_number parameter to 1 (#1870)
Set POT stat_requests_number parameter to 1 in order to lower RAM footprint

* [FIX] Training error when batch size is 1 (#1872)
fix: drop last batch

* Recover detection num_workers=2
* Remove nbmake from base requirements
* Add py.typed in package

* [FIX] Arrange scale between bbox preds and bbox targets in ATSS (#1880)
Arrange scale between bbox preds and bbox targets

* [FIX][RELEASE1.0] Remove cfg dump in ckpt (#1895)
* Remove cfg dump in ckpt
* Fix pre-commit

* Release v1.0.1

* [FIX] Prevent torch 2.0.0 installation (#1896)

* Add torchvision & torchtext in requirements/anomaly.txt with fixed version

* Update requirements/anomaly.txt

* Fix _model_cfg -> _recipe_cfg due to cfg merge

---------

Signed-off-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Prokofiev Kirill <kirill.prokofiev@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Nikita Savelyev <nikita.savelyev@intel.com>
Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com>
Co-authored-by: Jihwan Eom <jihwan.eom@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant