Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: auto adapt batch size doesn't work with cls incr case #2199

Merged

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented May 25, 2023

Summary

It's because ClsIncrSampler uses old dataset versus new dataset ratio, but subset for auto adapt batch size doesn't consider it.
This PR adds a code to set old dataset versus new dataset ratio as proper value which can works well with ClsIncrSampler.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels May 25, 2023
@eunwoosh eunwoosh changed the title Es/auto bs consider cls incr bugfix: auto adapt batch size doesn't work with cls incr case May 25, 2023
@eunwoosh eunwoosh requested a review from sungmanc May 25, 2023 07:06
@github-actions github-actions bot added the DOC Improvements or additions to documentation label May 25, 2023
@eunwoosh eunwoosh marked this pull request as ready for review May 25, 2023 07:08
@eunwoosh eunwoosh requested a review from a team as a code owner May 25, 2023 07:08
sungmanc
sungmanc previously approved these changes May 25, 2023
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

jaegukhyun
jaegukhyun previously approved these changes May 25, 2023
@jaegukhyun jaegukhyun added this to the 1.3.0 milestone May 25, 2023
@eunwoosh eunwoosh enabled auto-merge (squash) May 25, 2023 08:33
@eunwoosh eunwoosh changed the base branch from releases/1.3.0 to releases/1.3.1 May 26, 2023 01:10
@eunwoosh eunwoosh dismissed stale reviews from jaegukhyun and sungmanc May 26, 2023 01:10

The base branch was changed.

@eunwoosh eunwoosh merged commit 14caa3c into openvinotoolkit:releases/1.3.1 May 26, 2023
goodsong81 pushed a commit that referenced this pull request May 26, 2023
* auto adapt consider cls incremental case

* align with pre-commit

* update changelog
goodsong81 added a commit that referenced this pull request Jun 5, 2023
* Fix e2e (#2179)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Update noisy label det docs for detection task (#2183)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Add supcon seg for regression (#2177)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Update regression test config (#2186)

* Fix for anomaly regression test (#2188)

* Fix iseg regression (#2190)

* Set path to save pseudo masks into workspace (#2185)

* Temporary fix override_configs bug (#2187)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Cleaned up skip/xfail TCs on the classification e2e tests (#2196)

* Added csv output to export dependencies (#2178)

* Fix typo and enlarge the threshold for KPI tests (#2198)

* bugfix: auto adapt batch size doesn't work with cls incr case (#2199)

* Fix for ssd (#2197)

* Turn off persistent worker if num_worker is zero in classification task (#2208)

* Update test cases of common_semantic_segmentation_dataset (#2210)

* Optimize counting train & inference speed and memory consumption (#2172)

* Do not skip full img tile classifier + Fix Sequencial Export Issue (#2174)

* Add warning message to tiling parameter (#2193)

* Change the way to pad for instance-segmentation

* Hotfix: use 0 confidence threshold when computing best threshold based on F1

* Fix possible bw issue in exportable code (#2212)

* Fix ellipse load (#2214)

* Fix GT vs prediction order mismatch due to different sorting result (#2216)

* Return raw anomaly maps as metadata (#2217)

* Fix merge error, revert to pymongo w/o version spec

---------

Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com>
Co-authored-by: Vinnam Kim <vinnam.kim@intel.com>
Co-authored-by: Sungman Cho <sungman.cho@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
Co-authored-by: Kim, Sungchul <sungchul.kim@intel.com>
Co-authored-by: Yunchu Lee <yunchu.lee@intel.com>
Co-authored-by: Jihwan Eom <jihwan.eom@intel.com>
Co-authored-by: Eugene Liu <eugene.liu@intel.com>
Co-authored-by: sungmanc <sungmanc@intel.com>
Co-authored-by: Vladislav Sovrasov <sovrasov.vlad@gmail.com>
Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants