Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test cases of common_semantic_segmentation_dataset #2210

Merged

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented May 31, 2023

Summary

Reported by @jaegukhyun.
Test cases were single value images and caused that during self-sl single value pseudo masks were created.
And these pseudo masks weren't loaded because of SegmentationDatasetAdapter which removes background label.
Because these test cases are very edge cases, they should be changed.

Updated samples:
image

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungchul2 sungchul2 added this to the 1.3.1 milestone May 31, 2023
@sungchul2 sungchul2 requested a review from jaegukhyun May 31, 2023 08:34
@sungchul2 sungchul2 requested a review from a team as a code owner May 31, 2023 08:34
@github-actions github-actions bot added the TEST Any changes in tests label May 31, 2023
@sungchul2 sungchul2 force-pushed the update_selfsl_adapter branch from 86cca20 to 3c2d96e Compare May 31, 2023 08:38
jaegukhyun
jaegukhyun previously approved these changes May 31, 2023
goodsong81
goodsong81 previously approved these changes May 31, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@sungchul2 sungchul2 dismissed stale reviews from goodsong81 and jaegukhyun via a1cf78c June 1, 2023 02:09
@sungchul2 sungchul2 force-pushed the update_selfsl_adapter branch from 3c2d96e to a1cf78c Compare June 1, 2023 02:09
@goodsong81 goodsong81 enabled auto-merge (squash) June 1, 2023 05:19
@goodsong81 goodsong81 merged commit 34ff412 into openvinotoolkit:releases/1.3.1 Jun 1, 2023
@sungchul2 sungchul2 deleted the update_selfsl_adapter branch June 1, 2023 06:05
goodsong81 added a commit that referenced this pull request Jun 5, 2023
* Fix e2e (#2179)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Update noisy label det docs for detection task (#2183)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Add supcon seg for regression (#2177)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Update regression test config (#2186)

* Fix for anomaly regression test (#2188)

* Fix iseg regression (#2190)

* Set path to save pseudo masks into workspace (#2185)

* Temporary fix override_configs bug (#2187)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Cleaned up skip/xfail TCs on the classification e2e tests (#2196)

* Added csv output to export dependencies (#2178)

* Fix typo and enlarge the threshold for KPI tests (#2198)

* bugfix: auto adapt batch size doesn't work with cls incr case (#2199)

* Fix for ssd (#2197)

* Turn off persistent worker if num_worker is zero in classification task (#2208)

* Update test cases of common_semantic_segmentation_dataset (#2210)

* Optimize counting train & inference speed and memory consumption (#2172)

* Do not skip full img tile classifier + Fix Sequencial Export Issue (#2174)

* Add warning message to tiling parameter (#2193)

* Change the way to pad for instance-segmentation

* Hotfix: use 0 confidence threshold when computing best threshold based on F1

* Fix possible bw issue in exportable code (#2212)

* Fix ellipse load (#2214)

* Fix GT vs prediction order mismatch due to different sorting result (#2216)

* Return raw anomaly maps as metadata (#2217)

* Fix merge error, revert to pymongo w/o version spec

---------

Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com>
Co-authored-by: Vinnam Kim <vinnam.kim@intel.com>
Co-authored-by: Sungman Cho <sungman.cho@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
Co-authored-by: Kim, Sungchul <sungchul.kim@intel.com>
Co-authored-by: Yunchu Lee <yunchu.lee@intel.com>
Co-authored-by: Jihwan Eom <jihwan.eom@intel.com>
Co-authored-by: Eugene Liu <eugene.liu@intel.com>
Co-authored-by: sungmanc <sungmanc@intel.com>
Co-authored-by: Vladislav Sovrasov <sovrasov.vlad@gmail.com>
Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants