feat: single page index scan with predicate #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AssertSortedChip
chips/src/single_page_index_scan/page_index_scan_input/columns.rs
Outdated
Show resolved
Hide resolved
bfan05
changed the title
bfan05
changed the title
|
Resolves INT-1530 |
jonathanpwang
requested changes
Jun 17, 2024
There was a problem hiding this comment.
I think it is overall correct, but the code is hard to read and verbose due to the match statements. It would be better if the code can be abridged to reflect that: you check predicate by using one or both of is_less_than and is_equal, and its mostly a question of which one(s) to use and what arguments to put in the subair eval.
Tips that may help:
- move
matchstatements to functions of theenumitself - you can use
Optionto havematchreturnNonefor irrelevant branches
chips/src/single_page_index_scan/page_index_scan_input/columns.rs
Outdated
Show resolved
Hide resolved
jonathanpwang
approved these changes
Jun 18, 2024
chips/src/single_page_index_scan/page_index_scan_output/columns.rs
Outdated
Show resolved
Hide resolved
chips/src/single_page_index_scan/page_index_scan_output/columns.rs
Outdated
Show resolved
Hide resolved
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* feat: sorted_limbs chip checking each limb less than limb_bits bits * feat: completed sorted_limbs chip with tests * feat: SortedLimbsChip with LessThan subchip * feat: less_than subchip refactored * feat: rename SortedLimbsChip to AssertSortedChip and write LessThanChip tests * chore: change name of assert sorted chip * chore: fix names in tests for AssertSortedChip * chore: address comments * chore: cleanup * chore: change MAX from generic to instance field for LessThanChip and AssertSortedChip * feat: IsLessThanChip to compare two numbers * feat: IsLessThanTuple subchip for different limb_bits * feat: IsLessThanTupleChip subchip in AssertSortedChip * chore: address comments first pass * chore: refactor AssertSorted, IsEqual, IsLessThan, and IsLessThanTuple chips * chore: address comments * chore: eliminate high dim poly from IsLessThanTupleChip * chore: fix tests * chore: address comments for AssertSortedChip * chore: cleanup AssertSorted * chore: cleanup * chore: include roundtrip flatten and from_slice tests * feat: flatten and from_slice for IO and Aux columns * create files * chore: begin PageIndexScanChip * feat: prototype * feat: rename Chip to AirBridge * feat: single page index scan chip for less than predicate * feat: partitioned main * chore: cleanup index scan for less than predicate * feat: x as public value * feat: page index scan with comparator enum * feat: page index scan for greater than predicate * feat: page index scan for equal to predicates * feat: page index scan for less than or equal to predicate * feat: page index scan for greater than or equal to predicate * chore: cleanup some branches * chore: refactor code to reduce repetition * chore: cleanup PageIndexScanInputChip * chore: fix test * merge IsEqualVec columns * remove range_max from PageIndexScan chips * chore: address comments * feat: use FinalPage * chore: refactor index_scan_test * chore: address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single page index scan for predicates of the form index OP x, where OP is one of <, <=, =, >=, > and x is a private input