-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Emit signal when requests to the freeradius accounting view are processed successfully #341
Comments
devkapilbansal
added a commit
that referenced
this issue
Nov 15, 2021
devkapilbansal
added a commit
that referenced
this issue
Nov 15, 2021
codesankalp
pushed a commit
that referenced
this issue
Nov 21, 2021
codesankalp
pushed a commit
that referenced
this issue
Nov 29, 2021
codesankalp
pushed a commit
that referenced
this issue
Nov 29, 2021
codesankalp
pushed a commit
that referenced
this issue
Nov 29, 2021
nemesifier
pushed a commit
that referenced
this issue
Nov 29, 2021
Closes #341 Co-authored-by: sankalp <sankalp123427@gmail.com>
codesankalp
pushed a commit
that referenced
this issue
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before a successful response is returned from the freeradius accounting view, we need to emit a signal so we can connect to it from other parts of the application or from third party apps.
The signal should not be emitted if there was any error.
The signal could be called
radius_accounting_success
, we should pass as argument the radius accounting object instance and the request object.We shall add tests and docs for this signal. As for the docs, I think we'll need a new page called
signals.rst
in docs/source/developer, the signal should be documented as we document signals in other modules (eg: openwisp-controller).The text was updated successfully, but these errors were encountered: