Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Emit signal when requests to the freeradius accounting view are processed successfully #341

Closed
nemesifier opened this issue Nov 8, 2021 · 0 comments · Fixed by #350
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nemesifier
Copy link
Member

Before a successful response is returned from the freeradius accounting view, we need to emit a signal so we can connect to it from other parts of the application or from third party apps.

The signal should not be emitted if there was any error.

The signal could be called radius_accounting_success, we should pass as argument the radius accounting object instance and the request object.

We shall add tests and docs for this signal. As for the docs, I think we'll need a new page called signals.rst in docs/source/developer, the signal should be documented as we document signals in other modules (eg: openwisp-controller).

@nemesifier nemesifier added the enhancement New feature or request label Nov 8, 2021
@nemesifier nemesifier added this to the 0.3 release milestone Nov 8, 2021
nemesifier pushed a commit that referenced this issue Nov 29, 2021
Closes #341

Co-authored-by: sankalp <sankalp123427@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants