Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Send email when radius accounting session starts #343

Closed
nemesifier opened this issue Nov 8, 2021 · 0 comments · Fixed by #355
Closed

[feature] Send email when radius accounting session starts #343

nemesifier opened this issue Nov 8, 2021 · 0 comments · Fixed by #355
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nemesifier
Copy link
Member

nemesifier commented Nov 8, 2021

This depends on the following features:

We shall send an email with a one time login link to the user once the radius accounting session starts.

The flow should be something like the following:

  • if the radius accounting has just been created (eg: accounting type start)
  • initialize a celery task in the background
  • the celery task shall check whether there's any user in the organization of the radius accounting with the username specified in the radius accounting, if yes, it shall send the user an email with a text that communicates that a new session has been started and provide a one-time link to the user where they can close the session (log out from the networking service) and/or manage their account
  • it would be great to make sure that if the one-time link has expired, the user sees the wifi login page (instead of the page which says the link has expired)
  • I think we should add new fields to OrganizationRadiusSettings where we can let admins specify the login page URL (where users log in to the wifi service) and status page URL (where users can log out or manage their account)
  • we have to make sure the language used for the translations is the user preferred language described in [feature] Add user preferred language field openwisp-users#261, because the radius accounting is started by freeradius calling our API, therefore we do not have the information of the preferred language coming from the browser, for that reason we have to get the preferred language from the DB and activate the translations for that language (see translation.activate() in the django docs)
@nemesifier nemesifier added the enhancement New feature or request label Nov 8, 2021
@nemesifier nemesifier added this to the 0.3 release milestone Nov 8, 2021
@codesankalp codesankalp self-assigned this Nov 19, 2021
nemesifier added a commit that referenced this issue Jan 11, 2022
Closes #343

Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants