Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port new instances and types #119

Closed
2 of 4 tasks
filippomc opened this issue Nov 5, 2019 · 1 comment
Closed
2 of 4 tasks

Port new instances and types #119

filippomc opened this issue Nov 5, 2019 · 1 comment
Assignees
Labels

Comments

@filippomc
Copy link
Contributor

filippomc commented Nov 5, 2019

Now we are able to directly define instances on the geppetto model from the backend. New instances are coming inside variables a new container called "worlds". Old variables container is being deprecated from now on.

Features to implement:

  • Regenerate model
  • GEPPETTO.ModelFactory.allPaths should return the paths for all the worlds. The path will be [WORLDID].[VARIABLEORINSTANCEPATH] -> GEPPETTO.ModelFactory.fetchAllPotentialInstancePaths
  • Instances.getInstance must work with the new structure -> fill GEPPETTO.ModelFactory.allPathsIndexing
  • For instances, values should be easily accessible. Say we have an instance myworld.myInstance with a value of type JSON {"a": 1}. Instances.getInstance("myworld.myInstance").value.a should return 1
@filippomc filippomc self-assigned this Nov 5, 2019
@filippomc
Copy link
Contributor Author

@tarelli @gidili

filippomc added a commit that referenced this issue Nov 6, 2019
filippomc added a commit that referenced this issue Nov 7, 2019
filippomc added a commit that referenced this issue Nov 7, 2019
filippomc added a commit that referenced this issue Nov 7, 2019
filippomc added a commit that referenced this issue Nov 7, 2019
filippomc added a commit that referenced this issue Nov 8, 2019
filippomc added a commit that referenced this issue Nov 8, 2019
filippomc added a commit that referenced this issue Nov 8, 2019
filippomc added a commit that referenced this issue Nov 8, 2019
That comes with a quite extended refactoring to imports:
we cant' use define with Jest
filippomc added a commit that referenced this issue Nov 9, 2019
filippomc added a commit that referenced this issue Nov 9, 2019
The ordering of the paths is different from what we see in the browser.
Shouldn't matter anyway.
filippomc added a commit that referenced this issue Nov 9, 2019
filippomc added a commit that referenced this issue Nov 9, 2019
filippomc added a commit that referenced this issue Nov 9, 2019
filippomc added a commit that referenced this issue Nov 14, 2019
filippomc added a commit that referenced this issue Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant