blkdev.h: revalidate_disk removed #11967
Comments
behlendorf
added
the
Type: Building
|
@ckane are you interested in taking a look at this? |
|
thx I can check it out - is this an upcoming 5.13 regression? |
nvm I see the commit history above - I'll see if I can get this fixed tonight |
|
So the existing call in our code says the following: /*
* Force revalidation, to mimic the old behavior of
* check_disk_change()
*/I'm taking this, plus the Linux kernel commit earlier, to potentially indicate it is safe to remove this in cases where the |
|
Ok PR now linked above, passes checkstyle - so I'll let it run the other automated before I test it on my system tomorrow. |
|
I have the patched version running successfully for several hours across three nodes with no issues, but I am not doing anything fancy with disks (e.g. removal, reboots, hotswap, etc) or zvols (any changes). |
|
I eventually received the following WARNING in the zfs module |
|
Thanks - I am also seeing that too, but I was already seeing it in my dmesg prior to this change too. Thus far it doesn't seem to have caused any failure for me (though I do keep regular backups just in case). @behlendorf you able to confirm? It looks like I see it right about the time that the ZFS mounts occur on boot, but I am fairly certain it is not related to the removal of the |
|
Just reporting, I've seen the Here's the log if it helps: |
|
thanks @PiMaker , @65a - I think this is enough to conclude that this bug was introduced before the proposed change in this issue and related PR. I will open a new GH issue later tonight on this problem, and if I have time in the next week or so I will see if I can bisect to figure out what might have introduced the error - which could be difficult as it could be ZFS or Linux 5.12. @behlendorf I've been using this change regularly for a few days on recent builds from Linus's tree and it seems to be stable for me, so I think it is ready for merge. The above crash dumps seem to have been introduced by a completely separate recent change. |
|
Running without issue here for 10 days continuously, but haven't tried it on any data I can't replace. Reboot, encryption, and zfs container storage (with snapshots) seem to all be working, but not really stress testing anything. |
|
@ckane thanks for sorting this out. The proposed change looks good to me, and I agree it wouldn't be the cause of the warnings which have been reported here. |
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11967 Closes #11977
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11967 Closes openzfs#11977
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11967 Closes openzfs#11977
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11967 Closes #11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev> Co-authored-by: Coleman Kane <ckane@colemankane.org>
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11967 Closes openzfs#11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev> Co-authored-by: Coleman Kane <ckane@colemankane.org>
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11967 Closes #11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev> Co-authored-by: Coleman Kane <ckane@colemankane.org>
torvalds/linux@0f00b82#diff-79b436371fdb3ddf0e7ad9bd4c9afe05160f7953438e650a77519b882904c56b
DKMS is failing on latest kernel sources.
The text was updated successfully, but these errors were encountered: