linux 5.13 compat: bdevops->revalidate_disk() removed #11977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Signed-off-by: Coleman Kane <ckane@colemankane.org>
behlendorf
added
Status: Code Review Needed
|
running this on my live system for the past hour or so with no issues to speak of |
|
With the merge window closing this weekend, this appears to be the only outstanding blocker to 5.13 compatibility this cycle. |
behlendorf
approved these changes
May 11, 2021
behlendorf
added
Status: Accepted
13 tasks
ColinIanKing
approved these changes
May 11, 2021
There was a problem hiding this comment.
This is literally identical to the solution I worked on today and posted here: #12027 (comment)
This looks good and I've given the same fix a good thorough test on zfs on Ubuntu Linux 5.13-rc1 today, so I'm happy to approve this.
13 tasks
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
May 28, 2021
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11967 Closes openzfs#11977
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11967 Closes openzfs#11977
tonyhutter
pushed a commit
that referenced
this pull request
Jun 2, 2021
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11967 Closes #11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev> Co-authored-by: Coleman Kane <ckane@colemankane.org>
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jun 2, 2021
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11967 Closes openzfs#11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev> Co-authored-by: Coleman Kane <ckane@colemankane.org>
tonyhutter
pushed a commit
that referenced
this pull request
Jun 23, 2021
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11967 Closes #11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev> Co-authored-by: Coleman Kane <ckane@colemankane.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the
revalidate_disk() handler from struct block_device_operations. This
caused a regression, and this commit eliminates the call to it and the
assignment in the block_device_operations static handler assignment
code, when configure identifies that the kernel doesn't support that
API handler.
Fixes #11967
Description
Added new test to
config/to create macro toggling whetherblock_device_operationscontainsrevalidate_diskor not. Previous code assumes that it exists. Now, if it doesn't exist, then dependent code will be removed bycpp.How Has This Been Tested?
Build tested only so far, will test on live system tomorrow.
Types of changes
Checklist:
Signed-off-by.