Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make rpm fails #25

Closed
seriv opened this issue Jul 1, 2010 · 2 comments
Closed

make rpm fails #25

seriv opened this issue Jul 1, 2010 · 2 comments

Comments

@seriv
Copy link

seriv commented Jul 1, 2010

It can't find <sys/tsol/label_macro.h> and <sys/tsol/label.h> to include into lib/libspl/ltos.c.
Strange, make without specifying target works ok. Only 'make rpm' fails.

Making all in asm-x86_64

make[6]: Entering directory `/tmp/zfs-build-seriv-qAcU0y88/BUILD/zfs-0.5.0/lib/libspl'
[skip]
#   source='../../lib/libspl/ltos.c' object='ltos.lo' libtool=yes 
/bin/sh ../../libtool  --tag=CC --silent  --mode=compile gcc -DHAVE_CONFIG_H -include ../../zfs_config.h -I../../lib/libspl/include    -Wall -Wstrict-prototypes -fno-strict-aliasing -Werror -D_GNU_SOURCE -D__EXTENSIONS__ -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DTEXT_DOMAIN=\"zfs-linux-user\" -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c -o ltos.lo `test -f '../../lib/libspl/ltos.c' || echo './'`../../lib/libspl/ltos.c
../../lib/libspl/ltos.c:29:34: error: sys/tsol/label_macro.h: No such file or directory
../../lib/libspl/ltos.c:30:28: error: sys/tsol/label.h: No such file or directory
In file included from ../../lib/libspl/ltos.c:31:
../../lib/libspl/include/label.h:76: error: expected declaration specifiers or '...' before 'm_label_t'
../../lib/libspl/include/label.h:77: error: expected declaration specifiers or '...' before 'm_label_t'
../../lib/libspl/include/label.h:79: error: expected ')' before '*' token
../../lib/libspl/include/label.h:80: error: expected declaration specifiers or '...' before 'm_label_t'
cc1: warnings being treated as errors
[skip]
make[6]: *** [ltos.lo] Error 1
make[6]: Leaving directory `/tmp/zfs-build-seriv-qAcU0y88/BUILD/zfs-0.5.0/lib/libspl'
make[5]: *** [all-recursive] Error 1
make[5]: Leaving directory `/tmp/zfs-build-seriv-qAcU0y88/BUILD/zfs-0.5.0/lib/libspl'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/tmp/zfs-build-seriv-qAcU0y88/BUILD/zfs-0.5.0/lib'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/tmp/zfs-build-seriv-qAcU0y88/BUILD/zfs-0.5.0'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/tmp/zfs-build-seriv-qAcU0y88/BUILD/zfs-0.5.0'
error: Bad exit status from /tmp/zfs-build-seriv-qAcU0y88/TMP/rpm-tmp.462Djt (%build)


RPM build errors:
    Bad exit status from /tmp/zfs-build-seriv-qAcU0y88/TMP/rpm-tmp.462Djt (%build)
make[1]: *** [rpm-common] Error 1
make[1]: Leaving directory `/home/seriv/work/zfs'
make: *** [rpm-utils] Error 2
@behlendorf
Copy link
Contributor

OK, thanks for trying this I meant to verify the RPM builds were still working after the update to onnv_141 but it slipped by mind. Anyway, I've pushed 3 fixes in to the tree which address the issues I saw when building packages. If you get a chance please try it again.

Use VERIFY() for asprintf due to rpm -D_FORTIFY_SOURCE=2 (3b54f50)

Add missing headers to 'make dist' target for RPM build (bb4baf0)

Update zfs.spec.in to reference updated README.markdown file (8db31e2)

@seriv
Copy link
Author

seriv commented Jul 1, 2010

Thank you, make rpm now works.
-- Sergey.

FransUrbo pushed a commit to FransUrbo/zfs that referenced this issue May 2, 2013
@zfsrogue
Merge pull request openzfs#25 from FransUrbo/fixes.crypto
c3b1a62 
Fix key retreival, keyformat==raw and crypto info in manpage
@dward dward mentioned this issue Aug 26, 2013
Closed
@tomposmiko tomposmiko mentioned this issue Apr 10, 2014
Closed
@dswartz dswartz mentioned this issue Apr 22, 2015
Closed
akatrevorjay added a commit to akatrevorjay/zfs that referenced this issue Dec 16, 2017
@akatrevorjay
# This is a combination of 56 commits.
4ae6a0d 
# This is the 1st commit message:
Merge branch 'master' of https://github.com/zfsonlinux/zfs

* 'master' of https://github.com/zfsonlinux/zfs:
  Enable QAT support in zfs-dkms RPM

# This is the commit message openzfs#2:

Import 0.6.5.7-0ubuntu3

# This is the commit message openzfs#3:

gbp changes

# This is the commit message openzfs#4:

Bump ver

# This is the commit message openzfs#5:

-j9 baby

# This is the commit message openzfs#6:

Up

# This is the commit message openzfs#7:

Yup

# This is the commit message openzfs#8:

Add new module

# This is the commit message openzfs#9:

Up

# This is the commit message openzfs#10:

Up

# This is the commit message openzfs#11:

Bump

# This is the commit message openzfs#12:

Grr

# This is the commit message openzfs#13:

Yay

# This is the commit message openzfs#14:

Yay

# This is the commit message openzfs#15:

Yay

# This is the commit message openzfs#16:

Yay

# This is the commit message openzfs#17:

Yay

# This is the commit message openzfs#18:

Yay

# This is the commit message openzfs#19:

yay

# This is the commit message openzfs#20:

yay

# This is the commit message openzfs#21:

yay

# This is the commit message openzfs#22:

Update ppa script

# This is the commit message openzfs#23:

Update gbp conf with br changes

# This is the commit message openzfs#24:

Update gbp conf with br changes

# This is the commit message openzfs#25:

Bump

# This is the commit message openzfs#26:

No pristine

# This is the commit message openzfs#27:

Bump

# This is the commit message openzfs#28:

Lol whoops

# This is the commit message openzfs#29:

Fix name

# This is the commit message openzfs#30:

Fix name

# This is the commit message openzfs#31:

rebase

# This is the commit message openzfs#32:

Bump

# This is the commit message openzfs#33:

Bump

# This is the commit message openzfs#34:

Bump

# This is the commit message openzfs#35:

Bump

# This is the commit message openzfs#36:

ntrim

# This is the commit message openzfs#37:

Bump

# This is the commit message openzfs#38:

9

# This is the commit message openzfs#39:

Bump

# This is the commit message openzfs#40:

Bump

# This is the commit message openzfs#41:

Bump

# This is the commit message openzfs#42:

Revert "9"

This reverts commit de488f1.

# This is the commit message openzfs#43:

Bump

# This is the commit message openzfs#44:

Account for zconfig.sh being removed

# This is the commit message openzfs#45:

Bump

# This is the commit message openzfs#46:

Add artful

# This is the commit message openzfs#47:

Add in zed.d and zpool.d scripts

# This is the commit message openzfs#48:

Bump

# This is the commit message openzfs#49:

Bump

# This is the commit message openzfs#50:

Bump

# This is the commit message openzfs#51:

Bump

# This is the commit message openzfs#52:

ugh

# This is the commit message openzfs#53:

fix zed upgrade

# This is the commit message openzfs#54:

Bump

# This is the commit message openzfs#55:

conf file zed.d

# This is the commit message #56:

Bump
allanjude added a commit to allanjude/zfs that referenced this issue Jun 12, 2018
@allanjude
Reserve DMU_BACKUP_FEATURE for ZSTD
0d0e42c 
Reserve openzfs#25 for the ZSTD compression feature from FreeBSD.
@allanjude allanjude mentioned this issue Jun 12, 2018
Merged
13 tasks
@niksfirefly niksfirefly mentioned this issue Jun 20, 2018
Closed
@fwaggle fwaggle mentioned this issue Jun 26, 2018
Closed
@jasimmons1973 jasimmons1973 mentioned this issue Apr 23, 2019
Merged
12 tasks
@aaronjwood aaronjwood mentioned this issue Dec 8, 2019
Closed
markroper added a commit to markroper/zfs that referenced this issue Feb 12, 2020
@markroper
Prevent deadlock in arc_read in Linux memory reclaim callback
6ac3449 
Using zfs with Lustre, an arc_read can trigger kernel memory allocation
that in turn leads to a memory reclaim callback and a deadlock within a
single zfs process. This change uses spl_fstrans_mark and
spl_trans_unmark to prevent the reclaim attempt and the deadlock
(https://zfsonlinux.topicbox.com/groups/zfs-devel/T4db2c705ec1804ba).
The stack trace observed is:

     #0 [ffffc9002b98adc8] __schedule at ffffffff81610f2e
     openzfs#1 [ffffc9002b98ae68] schedule at ffffffff81611558
     openzfs#2 [ffffc9002b98ae70] schedule_preempt_disabled at ffffffff8161184a
     openzfs#3 [ffffc9002b98ae78] __mutex_lock at ffffffff816131e8
     openzfs#4 [ffffc9002b98af18] arc_buf_destroy at ffffffffa0bf37d7 [zfs]
     openzfs#5 [ffffc9002b98af48] dbuf_destroy at ffffffffa0bfa6fe [zfs]
     openzfs#6 [ffffc9002b98af88] dbuf_evict_one at ffffffffa0bfaa96 [zfs]
     openzfs#7 [ffffc9002b98afa0] dbuf_rele_and_unlock at ffffffffa0bfa561 [zfs]
     openzfs#8 [ffffc9002b98b050] dbuf_rele_and_unlock at ffffffffa0bfa32b [zfs]
     openzfs#9 [ffffc9002b98b100] osd_object_delete at ffffffffa0b64ecc [osd_zfs]
    openzfs#10 [ffffc9002b98b118] lu_object_free at ffffffffa06d6a74 [obdclass]
    openzfs#11 [ffffc9002b98b178] lu_site_purge_objects at ffffffffa06d7fc1 [obdclass]
    openzfs#12 [ffffc9002b98b220] lu_cache_shrink_scan at ffffffffa06d81b8 [obdclass]
    openzfs#13 [ffffc9002b98b278] shrink_slab at ffffffff811ca9d8
    openzfs#14 [ffffc9002b98b338] shrink_node at ffffffff811cfd94
    openzfs#15 [ffffc9002b98b3b8] do_try_to_free_pages at ffffffff811cfe63
    openzfs#16 [ffffc9002b98b408] try_to_free_pages at ffffffff811d01c4
    openzfs#17 [ffffc9002b98b488] __alloc_pages_slowpath at ffffffff811be7f2
    openzfs#18 [ffffc9002b98b580] __alloc_pages_nodemask at ffffffff811bf3ed
    openzfs#19 [ffffc9002b98b5e0] new_slab at ffffffff81226304
    openzfs#20 [ffffc9002b98b638] ___slab_alloc at ffffffff812272ab
    openzfs#21 [ffffc9002b98b6f8] __slab_alloc at ffffffff8122740c
    openzfs#22 [ffffc9002b98b708] kmem_cache_alloc at ffffffff81227578
    openzfs#23 [ffffc9002b98b740] spl_kmem_cache_alloc at ffffffffa048a1fd [spl]
    openzfs#24 [ffffc9002b98b780] arc_buf_alloc_impl at ffffffffa0befba2 [zfs]
    openzfs#25 [ffffc9002b98b7b0] arc_read at ffffffffa0bf0924 [zfs]
    openzfs#26 [ffffc9002b98b858] dbuf_read at ffffffffa0bf9083 [zfs]
    openzfs#27 [ffffc9002b98b900] dmu_buf_hold_by_dnode at ffffffffa0c04869 [zfs]

Signed-off-by: Mark Roper <markroper@gmail.com>
allanjude pushed a commit to KlaraSystems/zfs that referenced this issue Apr 28, 2020
Merge pull request openzfs#25 from bgly/merge0.8.3
fbbad9c 
Merge0.8.3
@mattmacy mattmacy mentioned this issue Sep 22, 2020
Closed
12 tasks
@justinpryzby justinpryzby mentioned this issue Mar 16, 2021
Closed
@neurotensin neurotensin mentioned this issue Feb 5, 2024
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behlendorf @seriv