Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip reading any metaslab-related metadata when importing a pool readonly #9095

Closed
sdimitro opened this issue Jul 29, 2019 · 1 comment
Closed

Skip reading any metaslab-related metadata when importing a pool readonly #9095

sdimitro opened this issue Jul 29, 2019 · 1 comment
Assignees
@sdimitro
Labels
Type: Feature Feature request or new feature

Comments

@sdimitro
Copy link
Contributor

It would be great if we could skip reading metaslab-related data when importing the pool readonly.

The main reason for having such feature would be to help in recovery of data in failure scenarios where space-accounting and its relevant on-disk state have been corrupted but we still want to access the pool's data.
@sdimitro sdimitro added the Type: Feature Feature request or new feature label Jul 29, 2019
@sdimitro sdimitro self-assigned this Jul 29, 2019
@behlendorf
Copy link
Contributor

I thought this was already the case, for exactly the reason you mentioned. But looking at the git history it appears we made a change along these lines 7fc8c33, but reverted it afe3732 due to some ztest failures (which I'm sure can be fixed). As part of this, we should make sure to add a test case for this since it would be easily to accidentally break this an not notice.

fuporovvStack added a commit to fuporovvStack/zfs that referenced this issue Oct 26, 2021
@fuporovvStack
Skip spacemaps reading in case of pool readonly import
2b56db3 
The only zdb utility require to read metaslab-related data during
read-only pool import because of spacemaps validation. Add global
varialbe which will allow zdb read spacemaps in case of readonly
import mode.

Signed-off-by: Fedor Uporov <fuporov.vstack@gmail.com>
Closes openzfs#9095
@fuporovvStack fuporovvStack mentioned this issue Oct 26, 2021
Merged
13 tasks
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Apr 27, 2022
@fuporovvStack @behlendorf
Skip spacemaps reading in case of pool readonly import
44e0663 
The only zdb utility require to read metaslab-related data during
read-only pool import because of spacemaps validation. Add global
variable which will allow zdb read spacemaps in case of readonly
import mode.

Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Fedor Uporov <fuporov.vstack@gmail.com>
Closes openzfs#9095
Closes openzfs#12687
behlendorf added a commit that referenced this issue Apr 28, 2022
@behlendorf
Skip spacemaps reading in case of pool readonly import
ce8d41e 
The only zdb utility require to read metaslab-related data during
read-only pool import because of spacemaps validation. Add global
variable which will allow zdb read spacemaps in case of readonly
import mode.

Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Fedor Uporov <fuporov.vstack@gmail.com>
Closes #9095
Closes #12687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdimitro sdimitro

Labels
Type: Feature Feature request or new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behlendorf @sdimitro