Skip spacemaps reading in case of pool readonly import #12687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only zdb utility require to read metaslab-related data during read-only pool import because of spacemaps validation. Add global varialbe which will allow zdb read spacemaps in case of readonly import mode. Signed-off-by: Fedor Uporov <fuporov.vstack@gmail.com> Closes openzfs#9095
behlendorf
reviewed
Oct 27, 2021
behlendorf
approved these changes
Oct 29, 2021
behlendorf
added
Status: Accepted
sdimitro
approved these changes
Nov 9, 2021
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Apr 27, 2022
The only zdb utility require to read metaslab-related data during read-only pool import because of spacemaps validation. Add global variable which will allow zdb read spacemaps in case of readonly import mode. Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Fedor Uporov <fuporov.vstack@gmail.com> Closes openzfs#9095 Closes openzfs#12687
13 tasks
behlendorf
added a commit
that referenced
this pull request
Apr 28, 2022
The only zdb utility require to read metaslab-related data during read-only pool import because of spacemaps validation. Add global variable which will allow zdb read spacemaps in case of readonly import mode. Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Fedor Uporov <fuporov.vstack@gmail.com> Closes #9095 Closes #12687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Close issue #9095
The only zdb utility require to read metaslab-related data during
read-only pool import because of spacemaps validation. Add global
variable which will allow zdb read spacemaps in case of readonly
import mode.
Description
As was explained in the #9095, the proposed change allows to keep access to pool data if spacemaps were corrupted.
How Has This Been Tested?
It is not clear how it could be tested from users side, but if spacemaps will become unavailable for zdb, a bunch of zfs testsuite test cases will be broken.
Types of changes
Checklist:
Signed-off-by.