contrib: link zpool to zfs in bash-completion

[Harry-Chen]

Motivation and Context

Currently user won't have completion of zpool command until they trigger completion of zfs first. This patch adds a link to zfs, thus user can use both to initialize the completion.

Fixes: #16320

Description

Create a symlink to zfs as zpool under contrib/bash_completion.d.

How Has This Been Tested?

Tested the whole configuration, compilation and installation process. It wors as expected. No other functionality is affected.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[tonyhutter]

Can we get more more reviewer on this PR?

[robn]

It hardly matters, and I have no real opinion nor any idea what good practice is for completion scripts, but:

Would it be better to install this as a hard link instead of a symlink, or even a whole separate copy of the file?

[Harry-Chen]

It hardly matters, and I have no real opinion nor any idea what good practice is for completion scripts, but:
Would it be better to install this as a hard link instead of a symlink, or even a whole separate copy of the file?

I look at /usr/share/bash-completion/completions on my debian system, and many packages choose to use a symlink, e.g. vg* all go to lvm, and lxc_* go to _lxc. I think making hard links or copying might be confusing to users, and a symlink clearly shows the relationship between files.

[robn]

Works for me, thanks for checking 👍

[tonyhutter]

For some reason the Centos and Fedora builders were failing. I just started a re-run of those tests. If all goes well I will merge the PR.

[Harry-Chen]

For some reason the Centos and Fedora builders were failing. I just started a re-run of those tests. If all goes well I will merge the PR.

There is an error

  CC       contrib/pam_zfs_key/pam_zfs_key_la-pam_zfs_key.lo
ln -s zfs contrib/bash_completion.d/zpool
ln: failed to create symbolic link 'contrib/bash_completion.d/zpool': File exists
make[4]: *** [Makefile:14165: contrib/bash_completion.d/zpool] Error 1

zpool is created and preserved in the release tarball, thus causing the File exists error when being created again.

Sorry for not finding such situation, I will fix it soon.

[Harry-Chen]

The building issue is now fixed. @tonyhutter