contrib: bash_completion.d: force zpool symlink recreation #16423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ln will fail if the target already exists, which causes make to bail out. Adding -f makes it more "compiler-like", overwriting the target instead. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
mcmilk
approved these changes
Aug 8, 2024
0mp
approved these changes
Aug 8, 2024
allanjude
approved these changes
Aug 8, 2024
behlendorf
approved these changes
Aug 8, 2024
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
ln will fail if the target already exists, which causes make to bail out. Adding -f makes it more "compiler-like", overwriting the target instead. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Allan Jude <allan@klarasystems.com> Reviewed-by: Mateusz Piotrowski <0mp@FreeBSD.org> Signed-off-by: Rob Norris <rob.norris@klarasystems.com> Closes openzfs#16423
ptr1337
pushed a commit
to CachyOS/zfs
that referenced
this pull request
Nov 14, 2024
ln will fail if the target already exists, which causes make to bail out. Adding -f makes it more "compiler-like", overwriting the target instead. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Reviewed-by: Allan Jude <allan@klarasystems.com> Reviewed-by: Mateusz Piotrowski <0mp@FreeBSD.org> Signed-off-by: Rob Norris <rob.norris@klarasystems.com> Closes openzfs#16423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sponsors: Klara, Inc., Wasabi Technology, Inc.]
Motivation and Context
Following #16376, rebuild fails if the
zpoolsymlink already exists (usually after a branch change).Description
lnwill fail if the target already exists, which causes make to bail out. Adding-fmakes it more "compiler-like", overwritingNote this is not fixing the same thing as #16422. That's a separate thing.
How Has This Been Tested?
By hand!
Before:
After:
Types of changes
Checklist:
Signed-off-by.