Updating bash completion build file #16422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 46ebd0a updated the build system to make symbolic link for zpool. However, this commit did not update the automake file to also add the symbolic link to the CLEANFILES variable. This is necessary so the link is removed when running make clean/distclean. Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
13 tasks
mcmilk
approved these changes
Aug 8, 2024
behlendorf
approved these changes
Aug 8, 2024
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
Commit 46ebd0a updated the build system to make symbolic link for zpool. However, this commit did not update the automake file to also add the symbolic link to the CLEANFILES variable. This is necessary so the link is removed when running make clean/distclean. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Brian Atkinson <batkinson@lanl.gov> Closes openzfs#16422
ptr1337
pushed a commit
to CachyOS/zfs
that referenced
this pull request
Nov 14, 2024
Commit 46ebd0a updated the build system to make symbolic link for zpool. However, this commit did not update the automake file to also add the symbolic link to the CLEANFILES variable. This is necessary so the link is removed when running make clean/distclean. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: Brian Atkinson <batkinson@lanl.gov> Closes openzfs#16422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 46ebd0a updated the build system to make symbolic link for zpool. However, this commit did not update the automake file to also add the symbolic link to the CLEANFILES variable. This is necessary so the link is removed when running make clean/distclean.
Updated build system to fix error when trying to rebuild the source after running make clean/distclean.
Motivation and Context
Fixes issue with build system.
Description
Added the symbolic link created to the CLEANFILES variable in the automake file. Before this patch the following error would be issued after running make clean/distclean and then trying to rebuild the ZFS source:
ln -s zfs contrib/bash_completion.d/zpool CCLD tests/zfs-tests/tests/functional/vdev_disk/page_alignment ln: failed to create symbolic link 'contrib/bash_completion.d/zpool': File exists make[2]: *** [Makefile:14110: contrib/bash_completion.d/zpool] Error 1How Has This Been Tested?
Built ZFS, ran make clean, and rebuilt the source code. Did the same thing with make distclean. With this patch, the build error is no longer reported when rebuilding the source code.
Distro: Centos Stream 8
Kernel: 4.18.0-408.el8.x86_64
Types of changes
Checklist:
Signed-off-by.