Autoconf udev rules substitution #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the variable substitution in the udev rule templates
according to the method described in the Autoconf manual;
Chapter 4.7.2: Installation Directory Variables.
The udev rules are improperly generated if the bindir parameter
overrides the prefix parameter during configure. For example:
# ./configure --prefix=/usr/local --bindir=/opt/zfs/bin
The udev helper is installed as /opt/zfs/bin/zpool_id, but the
corresponding udev rule has a different path:
# /usr/local/etc/udev/rules.d/60-zpool.rules
ENV{DEVTYPE}=="disk", IMPORT{program}="/usr/local/bin/zpool_id -d %p"
The @bindir@ variable expands to "${exec_prefix}/bin", so it cannot
be used instead of @Prefix@ directly.
This also applies to the zvol_id helper.
Closes #283.
Run autogen.sh using the same autotools versions as upstream: * autoconf-2.63 * automake-1.11.1 * libtool-2.2.6b
|
I don't think it is. That's one of the changes which didn't occur when I re-ran autogen.sh locally. Anyway, I ended up using your original patch and my autogen.sh results which looked clean. I'm closing this issue since they have been merged in to master. |
fuhrmannb
pushed a commit
to fuhrmannb/cstor
that referenced
this pull request
Nov 3, 2020
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
ahrens
pushed a commit
to ahrens/zfs
that referenced
this pull request
Apr 30, 2021
Signed-off-by: Don Brady <don.brady@delphix.com>
pcd1193182
pushed a commit
to pcd1193182/zfs
that referenced
this pull request
May 28, 2021
…penzfs#322) This reverts commit e2035aa.
mmaybee
pushed a commit
to mmaybee/openzfs
that referenced
this pull request
Apr 6, 2022
EchterAgo
added a commit
to EchterAgo/zfs
that referenced
this pull request
Oct 11, 2023
I used this test when diagnosing openzfs#281 and think it would be a good addition. This tests file sizes when pre-allocating a file. Expected values have been confirmed on NTFS, ReFS and FAT32. This test currently does not work on a SMB share with the Samba server because it reports a fixed cluster size based on a configuration option instead of getting the correct value from the underlying file system. ksmbd does not have the same issue, it correctly gets the values from the file system. So far this is untested with Windows SMB shares. This also makes `tests.py` use some helpers from `utils.py`. Signed-off-by: Axel Gembe <derago@gmail.com>
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
May 18, 2024
I used this test when diagnosing openzfs#281 and think it would be a good addition. This tests file sizes when pre-allocating a file. Expected values have been confirmed on NTFS, ReFS and FAT32. This test currently does not work on a SMB share with the Samba server because it reports a fixed cluster size based on a configuration option instead of getting the correct value from the underlying file system. ksmbd does not have the same issue, it correctly gets the values from the file system. So far this is untested with Windows SMB shares. This also makes `tests.py` use some helpers from `utils.py`. Signed-off-by: Axel Gembe <derago@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.