Provide a rc.d script for archlinux #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcd1193182
pushed a commit
to pcd1193182/zfs
that referenced
this pull request
May 28, 2021
…penzfs#322) This reverts commit e2035aa.
mmaybee
pushed a commit
to mmaybee/openzfs
that referenced
this pull request
Apr 6, 2022
The CACHE-HITS ratio percentage is calculated as `CacheHit` / `LookupForRead`. However, the agent also increments CacheHit when incrementing LookupForWrite (from `ZettaCache::heal()`). We call heal() when there's zettacache corruption, which should be very rare, but we also heal() for every scrub read. Because of this, when `zpool scrub` is running, the hits ratio is incorrectly high, often much more than 100%. Each write_block request results in a `ZettaCache::lookup_impl()`, to ensure that the block isn't already present due to a kernel crash. However, this is an implementation detail, and we expect these lookups to rarely hit, and to always find the index entry in the index chunk cache. So we don't need these "lookups" to show up in any kind of accounting. This commit revamps the cache hits accounting by counting only (and all) non-write lookups.
EchterAgo
added a commit
to EchterAgo/zfs
that referenced
this pull request
Nov 10, 2023
Without this git needs to track way too many changes. Signed-off-by: Axel Gembe <axel@gembe.net>
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
May 18, 2024
Without this git needs to track way too many changes. Signed-off-by: Axel Gembe <axel@gembe.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this does not include changes made by autogen.sh, the reason for that is that the diff shows unrelated changes.
A few lines include:
There is a lot of changes in config/ltmain.sh which are definitely not related.