-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible using the same default port that is used for Go and Helm #23
Comments
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/lifecycle frozen |
Hi @estroz @jmrodri, @fabianvf, Users can choose their ports as they wish. So, should we really consider it a breaking cange that can only be addressed for 2.0? Could we not address this one by changing the default port and adding the steps in the migration guide for those who would like to use the previous default one? See that we are not removing the flag and or commands only changing the default value in the case. Advantage: Less deviation, easier to keep maintained and supported, fewer customizations required on top to address the idea kubernetes-sigs/kubebuilder#2015, same reasons/motivations described in |
I really think changing the default port is a breaking change. Because if I do the same thing I did before my ports will be different. And I don't see a huge benefit to having the ports being the same. |
That is fine. I agree that is not a huge benefit too. Just some nit that I'd like to know if you could address before 2.0. Thank you for your time. |
@camilamacedo86: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Feature Request
Describe the problem you need a feature to resolve.
Add the probes for Ansible as the new flag --health-probe-bind-address was added in operator-framework/operator-sdk#4326.
To keep the backwards compatibility only Ansible is using the port
6789
. However, go and helm uses:8081
.So, I am as maintainer and SDK user would like to see ansible configured by default using the port
:8081
in order to be easier we give support and keep it maintained as for the users since is not required remember and memorize that each type of language is using a diff port by defaultDescribe the solution you'd like.
Replace the port
6789
for:8081
./language ansible
The text was updated successfully, but these errors were encountered: