-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Helm/Ansible plugins with the changes made for Golang ( go/v3 ) #4542
Comments
@camilamacedo86 can you please make separate issues for these things you think need aligning between Go and Ansible/Helm? It's hard to address issues like this because they have so many components, making discussion disjointed. Please close this issue once done. /triage support |
Hi @estroz,
The issue/task is : To ensure that ansible/v1 and helm/v1 is aligned with go/v3 as described. I raised a few points that I know that they are not. However, I understand that is part of this issue/task do the diffs and identify all changes as well. So. I am not sure how to split it. However, I am fine if who get it prefers to make many PRs instead of one to address the changes separately after identifying them. Is it make sense? Then, note that the fact of it be a hard job as its complexity only grows is one of the reasons that in pov makes it be required to get done as soon as possible as well (priority). I am looking for we no longer face this need in the future via the solution proposed in KB Extract config/base plugin valid for any language/type from Golang #2015 and its pre-requirements defined in the meta issue Plugins Ecosystem Next - Meta issue #2016. |
This isn't actionable or triage-able since there is no fix for this, and the requirements are ever-changing as each of the Go, Ansible, and Helm plugins adopts changes/fixes/features.
Take each one of the bullet points above in "Describe the solution you'd like" and make an issue if one doesn't exist already. Be sure to list the changes you're talking about so whoever works on the issue knows what to do. If you don't have a concrete example of what needs changing in Ansible/Helm plugins to align with existing changes in the Go plugin, then I don't see a reason to have an issue in the first place. |
HI @estroz, In the first comment, I described reasons and motivations for it be required in (
PS.: I added what directories required to be compared. In the past, I tried to ensure that KB and Ansible/Helm plugins had the templates files and etc with the same name and in the same directory looking to make this process easier in the future. Indeed IMO we can make an agreement until a better design solution is in place (kubernetes-sigs/kubebuilder#2015) that when we bump kb we try already to check the changes and to do the alignment in the same PR unless the PR is too big because we wait too much to do the sync or KB has too many changes. |
I assigned that to me too do this first steps at least and identify what we need to apply to keep all aligned. |
Regarding the changes in the config only Note that it is a hight effort to be done manually. Then we have already the PRs to apply 1.5 very shaped and prepared to get merged for we introduce the 1.5 kubernetes-sigs/kubebuilder#2060 / sdk alignment #4581. And then we might able to centralize it with kubernetes-sigs/kubebuilder#2015. |
As part of this task we have tracked now:
|
- Align Helm/Ansible with Go - Remove the duplication of the code - Bump KB - Add configComponent feature for Ansible/Helm **Motvation** Closes: operator-framework#4542 Closes: operator-framework#4643 Signed-off-by: Camila Macedo <cmacedo@redhat.com>
**Description** - Align Helm/Ansible with Go - Remove the duplication of the code - Bump KB - Add configComponent feature for Ansible/Helm **Motvation** Closes: operator-framework#4542 Closes: operator-framework#4643 Signed-off-by: Camila Macedo <cmacedo@redhat.com> dd
**Description** - Align Helm/Ansible with Go - Remove the duplication of the code - Bump KB - Add configComponent feature for Ansible/Helm **Motvation** Closes: operator-framework#4542 Closes: operator-framework#4643 Signed-off-by: Camila Macedo <cmacedo@redhat.com>
**Description** - Align Helm/Ansible with Go by making use of the common base and by removing the duplications - Align SDK with KB - Add configComponent feature for Ansible/Helm - Add a new plugin option to let users create only the common base with sdk **Motvation** Closes: operator-framework#4542 Closes: operator-framework#4643 Signed-off-by: Camila Macedo <cmacedo@redhat.com>
**Description** - Align Helm/Ansible with Go by making use of the common base and by removing the duplications - Align SDK with KB - Add configComponent feature for Ansible/Helm - Add a new plugin option to let users create only the common base with sdk **Motvation** Closes: operator-framework#4542 Closes: operator-framework#4643 Signed-off-by: Camila Macedo <cmacedo@redhat.com>
**Description** - Align Helm/Ansible with Go by making use of the common base and by removing the duplications - Align SDK with KB - Add configComponent feature for Ansible/Helm - Add a new plugin option to let users create only the common base with sdk **Motvation** Closes: operator-framework#4542 Closes: operator-framework#4643 Signed-off-by: Camila Macedo <cmacedo@redhat.com>
**Description** - Align Helm/Ansible with Go by making use of the common base and by removing the duplications - Align SDK with KB - Add configComponent feature for Ansible/Helm - Add a new plugin option to let users create only the common base with sdk **Motvation** Closes: operator-framework#4542 Closes: operator-framework#4643 Signed-off-by: Camila Macedo <cmacedo@redhat.com>
**Description** - Align Helm/Ansible with Go by making use of the common base and by removing the duplications - Align SDK with KB - Add configComponent feature for Ansible/Helm - Add a new plugin option to let users create only the common base with sdk **Motvation** Closes: operator-framework#4542 Closes: operator-framework#4643 Signed-off-by: Camila Macedo <cmacedo@redhat.com>
Describe the problem you need a feature to resolve.
Currently, Helm/Ansible plugins have been scaffolding the files common files ( config, makefile ) which are not aligned with the latest changes for Golang go/v3.
A few bad side effect regarding Helm/Ansible starts to deviate from Golang are:
Describe the solution you'd like.
--metrics-addr
andenable-leader-election
now are named--metrics-bind-address
and--leader-elect
to be more aligned with core Kubernetes Components. More info: (c-r v0.2.0) *: bump controller-runtime to v0.2.0, update APIs #1839. So, it is required to deprecated the old flags for Ansible/Helm and add the new ones and use them by default in the scaffold. It requires changes in the internal code for Ansible/Helm and scaffolds.Other significant changes to be addressed are:
SecurityContext
to address security concerns.Aditional Context
How to check the differences to do this sync/update?
internal/plugins/ansible/v1/scaffolds/internal/templates/config
with https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/plugins/golang/v3/scaffolds/internal/templates/config (kb bumped version)internal/plugins/helm/v1/scaffolds/internal/templates/config
with https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/plugins/golang/v3/scaffolds/internal/templates/config (kb bumped version)NOTE: See Plugins Ecosystem Next - Meta issue #2016. Note that the design proposed in Extract config/base plugin valid for any language/type from Golang #2015 can solve this current problem to keep the projects maintainable and aligned in the future.
The text was updated successfully, but these errors were encountered: