Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible/helm - apply the service account #4653

Merged

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Mar 13, 2021

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:32 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:32 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:32 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:32 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:32 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:32 Inactive
@camilamacedo86 camilamacedo86 changed the title ansible/helm - apply the service acount ansible/helm - apply the service account Mar 13, 2021
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:47 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:47 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:47 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:47 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:47 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 09:47 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:10 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:10 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:10 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:10 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:10 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:10 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:41 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:41 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:41 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:41 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:41 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 13, 2021 10:41 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 16, 2021 22:42 Inactive
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using the wrong license header.

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Mar 17, 2021

Hi @estroz,

You're using the wrong license header.

I am not. It is a copy and paste from KB. So, we should respect the license as in other places.

@estroz
Copy link
Member

estroz commented Mar 18, 2021

Ah I didn't realize you copied some of these files verbatim.

@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:56 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:56 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:56 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:56 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:56 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:56 Inactive
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:58 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:58 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:58 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:58 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:58 Inactive
@camilamacedo86 camilamacedo86 temporarily deployed to deploy March 18, 2021 01:58 Inactive
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
@camilamacedo86 camilamacedo86 merged commit c929783 into operator-framework:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible/Helm should also provide the specific Service Account
3 participants