-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible/helm - apply the service account #4653
ansible/helm - apply the service account #4653
Conversation
4988f8b
to
eb53d56
Compare
eb53d56
to
660be09
Compare
4871ca8
to
ff79c95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're using the wrong license header.
internal/plugins/ansible/v1/scaffolds/internal/templates/config/rbac/service_account.go
Show resolved
Hide resolved
Hi @estroz,
I am not. It is a copy and paste from KB. So, we should respect the license as in other places. |
Ah I didn't realize you copied some of these files verbatim. |
website/content/en/docs/building-operators/ansible/migration.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/building-operators/ansible/migration.md
Outdated
Show resolved
Hide resolved
8fb8252
to
705404f
Compare
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
705404f
to
3c99253
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
Motivation for the change:
Closes: Ansible/Helm should also provide the specific Service Account #4644
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs