deps: bump kubebuilder to dd3942c #4626
Conversation
openshift-ci-robot
added
the
area/dependency
There was a problem hiding this comment.
Just a nit/suggestion to improve the changelog. See: https://github.com/operator-framework/operator-sdk/pull/4626/files#r590915456.
Otherwise it shows ok for me 👍
I checked the changes upstream from one version to another and all shows fine too.
I mean, all required entries are addressed in the changelog.
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
| @@ -228,6 +228,15 @@ See the complete migrated `memcached_controller.go` code [here][memcached_contro | |||
|
|
|||
| **Note:** The version of [controller-runtime][controller-runtime] used in the projects scaffolded by SDK `0.19.x+` was `v0.6.0`. Please check [sigs.k8s.io/controller-runtime release docs from 0.7.0+ version][controller-runtime] for breaking changes. | |||
|
|
|||
| ##### Updating your ServiceAccount in Go operator projects | |||
There was a problem hiding this comment.
@estroz I just realized that in Go operator projects is not required here. See that it is the Golang migration guide so it is all about Go-based operators. Also, should we not add any info in the https://master.sdk.operatorframework.io/docs/building-operators/golang/operator-scope/ docs as well?
Also, I think we need to update ansible and helm before 1.5 regards this one too for doing no start o b very confuse.
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
| ```console | ||
| $ operator-sdk scorecard <bundle_dir_or_image> --service-account=mycustomsa | ||
| $ operator-sdk scorecard <bundle_dir_or_image> --service-account=my-project-controller-manager |
There was a problem hiding this comment.
Not really, since the service account name is arbitrary.
**Description of the change:** - create and bind to a non-default service account - follow up : kubernetes-sigs/kubebuilder#2070 and #4626 **Motivation for the change:** - fix: Scorecard docs instructions are wrong now for Ansible/Helm - rfe: apply the same go behaviour of Go default config for Ansible/Helm - Reduce the complexities for we address kubernetes-sigs/kubebuilder#2015 - Keep Ansible/Helm/Go aligned (Align Helm/Ansible plugins with the changes made for Golang ( go/v3 )) Closes: #4644
Description of the change:
Motivation for the change: recent changes in kubebuilder
Closes #4468
/area dependency
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs