Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible/Helm providing the same flags as Go #4627

Closed
camilamacedo86 opened this issue Mar 10, 2021 · 0 comments
Closed

Ansible/Helm providing the same flags as Go #4627

camilamacedo86 opened this issue Mar 10, 2021 · 0 comments
Assignees
@camilamacedo86
Labels
language/ansible Issue is related to an Ansible operator project language/helm Issue is related to a Helm operator project
Milestone
Backlog

Comments

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Mar 10, 2021 •
edited

Feature Request

Describe the problem you need a feature to resolve.

Ansible/Helm are deviating from Golang related to the flags used.

Note that one of the changes made in Golang is: The manager flags --metrics-addr and enable-leader-election now are named --metrics-bind-address and --leader-elect to be more aligned with core Kubernetes Components. More info: #1839..

Describe the solution you'd like.

So, it is required to deprecated the old flags for Ansible/Helm and add the new ones and use them by default in the scaffold. It requires changes in the internal code for Ansible/Helm and scaffolds

Motivation: #4542
@camilamacedo86 camilamacedo86 changed the title Ansible/Helm are not providing the same flags as Go Ansible/Helm providing the same flags as Go Mar 10, 2021
@camilamacedo86 camilamacedo86 added language/ansible Issue is related to an Ansible operator project language/helm Issue is related to a Helm operator project labels Mar 10, 2021
This was referenced Mar 12, 2021
Closed
Merged
@camilamacedo86 camilamacedo86 self-assigned this Mar 13, 2021
@jberkhahn jberkhahn added this to the Backlog milestone Mar 15, 2021
camilamacedo86 added a commit that referenced this issue Mar 18, 2021
@camilamacedo86
ansible/helm : aling flags and deprecated the old ones (#4654)
348e7de 
**Description of the change:**
- Deprecated the flags which were removed in the Golang project in order to keep it better aligned with K8S
- Add the new flags
- Ensure that that metrics port is passed to the proxy. 

**Motivation for the change:**

- Reduce the complexities for we address kubernetes-sigs/kubebuilder#2015
- Fix docs that were not updated.
- Keep Ansible/Helm/Go aligned (Align Helm/Ansible plugins with the changes made for Golang ( go/v3 ))
- Closes: Ansible/Helm providing the same flags as Go #4627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilamacedo86 camilamacedo86

Labels
language/ansible Issue is related to an Ansible operator project language/helm Issue is related to a Helm operator project
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jberkhahn @camilamacedo86