Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(c-r v0.2.0) *: bump controller-runtime to v0.2.0, update APIs #1839

Merged
merged 15 commits into from
Sep 3, 2019
Merged

(c-r v0.2.0) *: bump controller-runtime to v0.2.0, update APIs #1839

merged 15 commits into from
Sep 3, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Aug 19, 2019 •
edited
Loading

Description of the change:

  • bump controller-runtime versions to v0.2.0 (released 8/22)
  • pin controller-runtime versions in Ansible and Helm go.mod/Gopkg.toml scaffolds
  • update client.List() calls with new option pattern introduced in v0.2.0

Motivation for the change: controller-runtime merged an API options redux in v0.2.0-beta.5, then released v0.2.0. This PR modifies SDK code that uses affected APIs.

Migrated Ansible and Helm projects use controller-runtime directly in their cmd/manager/main.go files, so controller-runtime should be pinned in their go.mod/Gopkg.toml scaffolds.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2019
@estroz estroz changed the title [WIP] (c-r v0.2.0) *: bump controller-runtime to v0.2.0-rc.0, update APIs (c-r v0.2.0) *: bump controller-runtime to v0.2.0-rc.0, update APIs Aug 19, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2019
joelanford
joelanford reviewed Aug 21, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
internal/pkg/scaffold/ansible/go_mod.go Outdated Show resolved Hide resolved
internal/util/k8sutil/options.go Show resolved Hide resolved
internal/util/k8sutil/options.go Show resolved Hide resolved
test/e2e/_incluster-test-code/memcached_test.go Outdated Show resolved Hide resolved
@joelanford
Copy link
Member

@estroz Should we go ahead and bump directly to 0.2.0 now that it's released?

@estroz estroz requested a review from joelanford August 23, 2019 21:38
@estroz estroz changed the title (c-r v0.2.0) *: bump controller-runtime to v0.2.0-rc.0, update APIs (c-r v0.2.0) *: bump controller-runtime to v0.2.0, update APIs Aug 23, 2019
joelanford
joelanford approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing last few nits

doc/user/client.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
secat
secat reviewed Aug 27, 2019
View reviewed changes
doc/user/client.md Outdated Show resolved Hide resolved
hasbro17
hasbro17 reviewed Aug 29, 2019
View reviewed changes
doc/user/client.md Outdated Show resolved Hide resolved
@hasbro17
Update doc/user/client.md
71b9de5 
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
hasbro17
hasbro17 suggested changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just some nits and corrections in the client documentation.

doc/user/client.md Outdated Show resolved Hide resolved
doc/user/client.md Outdated Show resolved Hide resolved
doc/user/client.md Outdated Show resolved Hide resolved
doc/user/client.md Show resolved Hide resolved
doc/user/client.md Outdated Show resolved Hide resolved
doc/user/client.md Outdated Show resolved Hide resolved
doc/user/client.md Show resolved Hide resolved
pkg/test/client.go Show resolved Hide resolved
@hasbro17
Apply suggestions from code review
1cf87bc 
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
hasbro17
hasbro17 approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit 7968c5a into operator-framework:refactor/controller-runtime-v0.2.0 Sep 3, 2019
@estroz estroz deleted the c-r-v0.2.0-rc-0 branch September 3, 2019 23:35
@estroz estroz mentioned this pull request Sep 4, 2019
Merged
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 16, 2021
Closed
@camilamacedo86 camilamacedo86 mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@secat secat secat left review comments

@joelanford joelanford joelanford approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@fabianvf fabianvf Awaiting requested review from fabianvf

@theishshah theishshah Awaiting requested review from theishshah

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@estroz @joelanford @secat @hasbro17 @openshift-ci-robot