Align Helm/Ansible plugins using common/v3 base #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
plugins-kb
branch
from
c062730
to
ad8e09e
Compare
camilamacedo86
force-pushed
the
plugins-kb
branch
from
ad8e09e
to
fb58994
Compare
camilamacedo86
force-pushed
the
plugins-kb
branch
from
fb58994
to
9697936
Compare
camilamacedo86
commented
Mar 29, 2021
internal/cmd/operator-sdk/cli/cli.go
Outdated
| golangv2.Plugin{}, | ||
| envtestv1.Plugin{}, | ||
| manifestsv2.Plugin{}, | ||
| scorecardv2.Plugin{}, | ||
| ) | ||
| gov3Bundle, _ := plugin.NewBundle(golangv3.Plugin{}.Name(), golangv3.Plugin{}.Version(), | ||
| gov3Bundle, _ := plugin.NewBundle(golang.DefaultGoNameQualifier, golangv3.Plugin{}.Version(), | ||
| commonv3.Plugin{}, |
There was a problem hiding this comment.
We might not need to use the common here. see: kubernetes-sigs/kubebuilder#2112
There was a problem hiding this comment.
In order to do this, we need to export the bundle, which I have planned to do once kubernetes-sigs/kubebuilder#2106 is merged. (I'm not doing it right now to prevent rebases)
There was a problem hiding this comment.
we can do that in a follow-up. I will add a comment
openshift-ci-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
plugins-kb
branch
from
6396d7a
to
e63f7ff
Compare
openshift-ci-robot
removed
needs-rebase
camilamacedo86
force-pushed
the
plugins-kb
branch
2 times, most recently
from
2e52b0c
to
b8f0103
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
camilamacedo86
force-pushed
the
plugins-kb
branch
from
b8f0103
to
c9017c2
Compare
estroz
reviewed
Apr 7, 2021
| @@ -39,7 +39,9 @@ func (f *Kustomization) SetTemplateDefaults() error { | |||
|
|
|||
| f.TemplateBody = kustomizeTemplate | |||
|
|
|||
| f.IfExistsAction = machinery.Error | |||
| // For Anible/Helm is no supported webhooks then, we customize | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
estroz
reviewed
Apr 7, 2021
| @@ -39,7 +39,9 @@ func (f *Kustomization) SetTemplateDefaults() error { | |||
|
|
|||
| f.TemplateBody = kustomizeTemplate | |||
|
|
|||
| f.IfExistsAction = machinery.Error | |||
| // For Anible/Helm is no supported webhooks then, we customize | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
estroz
reviewed
Apr 7, 2021
internal/plugins/ansible/v1/init.go
Outdated
Comment on lines
191
to
193
| env: | ||
| - name: ANSIBLE_GATHERING | ||
| value: explicit` |
There was a problem hiding this comment.
Small nit to align YAML formatting
Suggested change
| env: | |
| - name: ANSIBLE_GATHERING | |
| value: explicit` | |
| env: | |
| - name: ANSIBLE_GATHERING | |
| value: explicit` |
estroz
approved these changes
Apr 7, 2021
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
camilamacedo86
force-pushed
the
plugins-kb
branch
from
3e24c25
to
742fc0c
Compare
waynesun09
added a commit
to waynesun09/reportportal-operator
that referenced
this pull request
Apr 22, 2021
Update related to v1.6.1 https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.6.1/ operator-framework/operator-sdk#4701 Signed-off-by: Wayne Sun <gsun@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motvation
Closes: #4542
Closes: #4643
Blocked by
kubernetes-sigs/kubebuilder#2106