-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Helm/Ansible plugins using common/v3 base #4701
Align Helm/Ansible plugins using common/v3 base #4701
Conversation
c062730
to
ad8e09e
Compare
ad8e09e
to
fb58994
Compare
fb58994
to
9697936
Compare
internal/cmd/operator-sdk/cli/cli.go
Outdated
golangv2.Plugin{}, | ||
envtestv1.Plugin{}, | ||
manifestsv2.Plugin{}, | ||
scorecardv2.Plugin{}, | ||
) | ||
gov3Bundle, _ := plugin.NewBundle(golangv3.Plugin{}.Name(), golangv3.Plugin{}.Version(), | ||
gov3Bundle, _ := plugin.NewBundle(golang.DefaultGoNameQualifier, golangv3.Plugin{}.Version(), | ||
commonv3.Plugin{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not need to use the common here. see: kubernetes-sigs/kubebuilder#2112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to do this, we need to export the bundle, which I have planned to do once kubernetes-sigs/kubebuilder#2106 is merged. (I'm not doing it right now to prevent rebases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can do that in a follow-up. I will add a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
6396d7a
to
e63f7ff
Compare
2e52b0c
to
b8f0103
Compare
/lgtm |
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
b8f0103
to
c9017c2
Compare
@@ -39,7 +39,9 @@ func (f *Kustomization) SetTemplateDefaults() error { | |||
|
|||
f.TemplateBody = kustomizeTemplate | |||
|
|||
f.IfExistsAction = machinery.Error | |||
// For Anible/Helm is no supported webhooks then, we customize |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
@@ -39,7 +39,9 @@ func (f *Kustomization) SetTemplateDefaults() error { | |||
|
|||
f.TemplateBody = kustomizeTemplate | |||
|
|||
f.IfExistsAction = machinery.Error | |||
// For Anible/Helm is no supported webhooks then, we customize |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
internal/plugins/ansible/v1/init.go
Outdated
env: | ||
- name: ANSIBLE_GATHERING | ||
value: explicit` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit to align YAML formatting
env: | |
- name: ANSIBLE_GATHERING | |
value: explicit` | |
env: | |
- name: ANSIBLE_GATHERING | |
value: explicit` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the formatting nit
/lgtm
New changes are detected. LGTM label has been removed. |
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
3e24c25
to
742fc0c
Compare
Update related to v1.6.1 https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.6.1/ operator-framework/operator-sdk#4701 Signed-off-by: Wayne Sun <gsun@redhat.com>
Description
Motvation
Closes: #4542
Closes: #4643
Blocked by
kubernetes-sigs/kubebuilder#2106