bump kubebuilder to v3.13.0 and fixup scaffolding #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Merged
| @@ -25,7 +25,7 @@ RUN set -e && yum clean all && rm -rf /var/cache/yum/* \ | |||
| && pip3 install --upgrade pip~=23.3.2 \ | |||
| && pip3 install pipenv==2023.11.15 \ | |||
| && pipenv install --deploy \ | |||
| && pipenv check \ | |||
| && pipenv check --ignore 70612 \ | |||
There was a problem hiding this comment.
What is this CVE and why are we ignoring it?
There was a problem hiding this comment.
This was a very old CVE that just got re-triggered, and is disputed in a few places.
GHSA-f6pv-j8mr-w6rr
dbt-labs/dbt-core#10250
https://data.safetycli.com/v/70612/97c/
everettraven
approved these changes
Jun 13, 2024
…sting, also adding an ignore to CVE-2019-8341(70612) in saftey scanning, since this is a transient dependency in the builder container Signed-off-by: Adam D. Cornett <adc@redhat.com>
|
New changes are detected. LGTM label has been removed. |
everettraven
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Bump Kubebuilder to v3.13.0 and fix up scaffolding to handle the incoming breaking changes.
Motivation for the change:
Operator SDK already bumped its kubebuilder dependency to v3.13.0, but it still uses a version of this package that is on a prior version.
Kubebuilder 3.13.0 seems to have made some changes in its
kustomizeplugin that break the expectations of downstream plugins (like this one)In order to fix things up, we need to also bump this repo to Kubebuilder v3.13.0, fix up its scaffolding to handle the incoming breaking changes, make a release, and then bump operator-sdk.
This PR is the first step of the process.